Patchwork [v2,04/06] net: ax25: fix misuse of %x

login
register
mail settings
Submitter Fuqian Huang
Date April 21, 2019, 11:48 a.m.
Message ID <20190421114806.20450-1-huangfq.daxian@gmail.com>
Download mbox | patch
Permalink /patch/777747/
State New
Headers show

Comments

Fuqian Huang - April 21, 2019, 11:48 a.m.
Pointers should be printed with %p or %px rather than
cast to long type and printed with %8.8lx.
Change %8.8lx to %p to print the pointer.

Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
---
 net/ax25/af_ax25.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
David Miller - April 21, 2019, 5:37 p.m.
From: Fuqian Huang <huangfq.daxian@gmail.com>
Date: Sun, 21 Apr 2019 19:48:06 +0800

> Pointers should be printed with %p or %px rather than
> cast to long type and printed with %8.8lx.
> Change %8.8lx to %p to print the pointer.
> 
> Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>

Applied to net-next.

Patch

diff --git a/net/ax25/af_ax25.c b/net/ax25/af_ax25.c
index 5d01edf..90c2831 100644
--- a/net/ax25/af_ax25.c
+++ b/net/ax25/af_ax25.c
@@ -1888,8 +1888,8 @@  static int ax25_info_show(struct seq_file *seq, void *v)
 	 * magic dev src_addr dest_addr,digi1,digi2,.. st vs vr va t1 t1 t2 t2 t3 t3 idle idle n2 n2 rtt window paclen Snd-Q Rcv-Q inode
 	 */
 
-	seq_printf(seq, "%8.8lx %s %s%s ",
-		   (long) ax25,
+	seq_printf(seq, "%p %s %s%s ",
+		   ax25,
 		   ax25->ax25_dev == NULL? "???" : ax25->ax25_dev->dev->name,
 		   ax2asc(buf, &ax25->source_addr),
 		   ax25->iamdigi? "*":"");