Patchwork [net-next] xen-netfront: mark expected switch fall-through

login
register
mail settings
Submitter Gustavo A. R. Silva
Date April 15, 2019, 9:11 p.m.
Message ID <20190415211141.GA1732@embeddedor>
Download mbox | patch
Permalink /patch/773665/
State New
Headers show

Comments

Gustavo A. R. Silva - April 15, 2019, 9:11 p.m.
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.

This patch fixes the following warning:

drivers/net/xen-netfront.c: In function ‘netback_changed’:
drivers/net/xen-netfront.c:2038:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
   if (dev->state == XenbusStateClosed)
      ^
drivers/net/xen-netfront.c:2041:2: note: here
  case XenbusStateClosing:
  ^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

Notice that, in this particular case, the code comment is modified
in accordance with what GCC is expecting to find.

This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
 drivers/net/xen-netfront.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Juergen Gross - April 16, 2019, 7:17 a.m.
On 15/04/2019 23:11, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
> 
> This patch fixes the following warning:
> 
> drivers/net/xen-netfront.c: In function ‘netback_changed’:
> drivers/net/xen-netfront.c:2038:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    if (dev->state == XenbusStateClosed)
>       ^
> drivers/net/xen-netfront.c:2041:2: note: here
>   case XenbusStateClosing:
>   ^~~~
> 
> Warning level 3 was used: -Wimplicit-fallthrough=3
> 
> Notice that, in this particular case, the code comment is modified
> in accordance with what GCC is expecting to find.
> 
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen
Gustavo A. R. Silva - April 16, 2019, 2:52 p.m.
On 4/16/19 2:17 AM, Juergen Gross wrote:
> On 15/04/2019 23:11, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> drivers/net/xen-netfront.c: In function ‘netback_changed’:
>> drivers/net/xen-netfront.c:2038:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>    if (dev->state == XenbusStateClosed)
>>       ^
>> drivers/net/xen-netfront.c:2041:2: note: here
>>   case XenbusStateClosing:
>>   ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> Notice that, in this particular case, the code comment is modified
>> in accordance with what GCC is expecting to find.
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> 
> Reviewed-by: Juergen Gross <jgross@suse.com>
> 

Thanks, Juergen.
--
Gustavo
David Miller - April 17, 2019, 4:03 a.m.
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>

Date: Mon, 15 Apr 2019 16:11:41 -0500

> In preparation to enabling -Wimplicit-fallthrough, mark switch

> cases where we are expecting to fall through.

> 

> This patch fixes the following warning:

> 

> drivers/net/xen-netfront.c: In function ‘netback_changed’:

> drivers/net/xen-netfront.c:2038:6: warning: this statement may fall through [-Wimplicit-fallthrough=]

>    if (dev->state == XenbusStateClosed)

>       ^

> drivers/net/xen-netfront.c:2041:2: note: here

>   case XenbusStateClosing:

>   ^~~~

> 

> Warning level 3 was used: -Wimplicit-fallthrough=3

> 

> Notice that, in this particular case, the code comment is modified

> in accordance with what GCC is expecting to find.

> 

> This patch is part of the ongoing efforts to enable

> -Wimplicit-fallthrough.

> 

> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>


Applied.

Patch

diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 80c30321de41..8d33970a2950 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -2037,7 +2037,7 @@  static void netback_changed(struct xenbus_device *dev,
 	case XenbusStateClosed:
 		if (dev->state == XenbusStateClosed)
 			break;
-		/* Missed the backend's CLOSING state -- fallthrough */
+		/* Fall through - Missed the backend's CLOSING state. */
 	case XenbusStateClosing:
 		xenbus_frontend_closed(dev);
 		break;