Patchwork [1/5] block/nvme: don't flip CQ phase bits

login
register
mail settings
Submitter Maxim Levitsky
Date April 15, 2019, 1:57 p.m.
Message ID <20190415135746.7571-2-mlevitsk@redhat.com>
Download mbox | patch
Permalink /patch/773161/
State New
Headers show

Comments

Maxim Levitsky - April 15, 2019, 1:57 p.m.
Phase bits are only set by the hardware to indicate new completions
and not by the device driver.

Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
---
 block/nvme.c | 2 --
 1 file changed, 2 deletions(-)

Patch

diff --git a/block/nvme.c b/block/nvme.c
index 0684bbd077..2d208000df 100644
--- a/block/nvme.c
+++ b/block/nvme.c
@@ -340,8 +340,6 @@  static bool nvme_process_completion(BDRVNVMeState *s, NVMeQueuePair *q)
         qemu_mutex_lock(&q->lock);
         c->cid = cpu_to_le16(0);
         q->inflight--;
-        /* Flip Phase Tag bit. */
-        c->status = cpu_to_le16(le16_to_cpu(c->status) ^ 0x1);
         progress = true;
     }
     if (progress) {