Patchwork [v3,1/2] dt-bindings: power: supply: Add charge-status-gpios property

login
register
mail settings
Submitter Artur Rojek
Date April 14, 2019, 12:40 p.m.
Message ID <20190414124039.10040-1-contact@artur-rojek.eu>
Download mbox | patch
Permalink /patch/772693/
State New
Headers show

Comments

Artur Rojek - April 14, 2019, 12:40 p.m.
Add documentation for the "charge-status-gpios" property.
Update the "gpios" property with a valid example.

Signed-off-by: Artur Rojek <contact@artur-rojek.eu>
Reviewed-by: Rob Herring <robh@kernel.org>
---

Changes:

v2: - add a better description for the "status-gpios" property,
    - add valid examples for the "gpios" and "status-gpios" properties

v3: rename the "status-gpios" property to "charge-status-gpios"

 .../devicetree/bindings/power/supply/gpio-charger.txt       | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
Sebastian Reichel - April 15, 2019, 8:09 p.m.
Hi,

On Sun, Apr 14, 2019 at 02:40:38PM +0200, Artur Rojek wrote:
> Add documentation for the "charge-status-gpios" property.
> Update the "gpios" property with a valid example.
> 
> Signed-off-by: Artur Rojek <contact@artur-rojek.eu>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---

Thanks, both queued.

-- Sebastian

> 
> Changes:
> 
> v2: - add a better description for the "status-gpios" property,
>     - add valid examples for the "gpios" and "status-gpios" properties
> 
> v3: rename the "status-gpios" property to "charge-status-gpios"
> 
>  .../devicetree/bindings/power/supply/gpio-charger.txt       | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/gpio-charger.txt b/Documentation/devicetree/bindings/power/supply/gpio-charger.txt
> index adbb5dc5b6e9..30349332f051 100644
> --- a/Documentation/devicetree/bindings/power/supply/gpio-charger.txt
> +++ b/Documentation/devicetree/bindings/power/supply/gpio-charger.txt
> @@ -14,12 +14,16 @@ Required properties :
>       usb-cdp (USB charging downstream port)
>       usb-aca (USB accessory charger adapter)
>  
> +Optional properties:
> + - charge-status-gpios: GPIO indicating whether a battery is charging.
> +
>  Example:
>  
>  	usb_charger: charger {
>  		compatible = "gpio-charger";
>  		charger-type = "usb-sdp";
> -		gpios = <&gpf0 2 0 0 0>;
> +		gpios = <&gpd 28 GPIO_ACTIVE_LOW>;
> +		charge-status-gpios = <&gpc 27 GPIO_ACTIVE_LOW>;
>  	}
>  
>  	battery {
> -- 
> 2.21.0
>

Patch

diff --git a/Documentation/devicetree/bindings/power/supply/gpio-charger.txt b/Documentation/devicetree/bindings/power/supply/gpio-charger.txt
index adbb5dc5b6e9..30349332f051 100644
--- a/Documentation/devicetree/bindings/power/supply/gpio-charger.txt
+++ b/Documentation/devicetree/bindings/power/supply/gpio-charger.txt
@@ -14,12 +14,16 @@  Required properties :
      usb-cdp (USB charging downstream port)
      usb-aca (USB accessory charger adapter)
 
+Optional properties:
+ - charge-status-gpios: GPIO indicating whether a battery is charging.
+
 Example:
 
 	usb_charger: charger {
 		compatible = "gpio-charger";
 		charger-type = "usb-sdp";
-		gpios = <&gpf0 2 0 0 0>;
+		gpios = <&gpd 28 GPIO_ACTIVE_LOW>;
+		charge-status-gpios = <&gpc 27 GPIO_ACTIVE_LOW>;
 	}
 
 	battery {