Patchwork [PATCHv5,18/20] PCI: mobiveil: Disable IB and OB windows set by bootloader

login
register
mail settings
Submitter Zhiqiang Hou
Date April 12, 2019, 8:37 a.m.
Message ID <20190412083635.33626-19-Zhiqiang.Hou@nxp.com>
Download mbox | patch
Permalink /patch/771355/
State New
Headers show

Comments

Zhiqiang Hou - April 12, 2019, 8:37 a.m.
From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>


Disable all inbound and outbound windows before set up the windows
in kernel, in case transactions match the window set by bootloader.

Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>

Reviewed-by: Minghuan Lian <Minghuan.Lian@nxp.com>

Reviewed-by: Subrahmanya Lingappa <l.subrahmanya@mobiveil.co.in>

---
V5:
 - No functionality change.

 drivers/pci/controller/pcie-mobiveil.c | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

-- 
2.17.1

Patch

diff --git a/drivers/pci/controller/pcie-mobiveil.c b/drivers/pci/controller/pcie-mobiveil.c

index 8dc87c7a600e..411e9779da12 100644

--- a/drivers/pci/controller/pcie-mobiveil.c

+++ b/drivers/pci/controller/pcie-mobiveil.c

@@ -565,6 +565,24 @@  static int mobiveil_bringup_link(struct mobiveil_pcie *pcie)

 	return -ETIMEDOUT;
 }
 
+static void mobiveil_pcie_disable_ib_win(struct mobiveil_pcie *pcie, int idx)

+{

+	u32 val;

+

+	val = csr_readl(pcie, PAB_PEX_AMAP_CTRL(idx));

+	val &= ~(1 << AMAP_CTRL_EN_SHIFT);

+	csr_writel(pcie, val, PAB_PEX_AMAP_CTRL(idx));

+}

+

+static void mobiveil_pcie_disable_ob_win(struct mobiveil_pcie *pcie, int idx)

+{

+	u32 val;

+

+	val = csr_readl(pcie, PAB_AXI_AMAP_CTRL(idx));

+	val &= ~(1 << WIN_ENABLE_SHIFT);

+	csr_writel(pcie, val, PAB_AXI_AMAP_CTRL(idx));

+}

+

 static void mobiveil_pcie_enable_msi(struct mobiveil_pcie *pcie)
 {
 	phys_addr_t msg_addr = pcie->pcie_reg_base;
@@ -585,6 +603,13 @@  static int mobiveil_host_init(struct mobiveil_pcie *pcie)

 {
 	u32 value, pab_ctrl, type;
 	struct resource_entry *win;
+	int i;

+

+	/* Disable all inbound/outbound windows */

+	for (i = 0; i < pcie->apio_wins; i++)

+		mobiveil_pcie_disable_ob_win(pcie, i);

+	for (i = 0; i < pcie->ppio_wins; i++)

+		mobiveil_pcie_disable_ib_win(pcie, i);

 
 	/* setup bus numbers */
 	value = csr_readl(pcie, PCI_PRIMARY_BUS);