Patchwork [dpdk-dev,v4] net/ixgbe: Restore vlan filter for ixgbevf

login
register
mail settings
Submitter David Harton
Date March 15, 2019, 4:08 p.m.
Message ID <20190315160832.34127-1-dharton@cisco.com>
Download mbox | patch
Permalink /patch/749695/
State New
Headers show

Comments

David Harton - March 15, 2019, 4:08 p.m.
ixgbevf vlan strip and extend capabilities were removed when
migrating to the bit flags implementation.

Restoring the capbility to enable the vlan strip offload at
configuration time.

Fixes: ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\")
Signed-off-by: David Harton <dharton@cisco.com>
---

 v4: fixed commit headline/log
 v3: restored ixgbe_is_vf() and only restore VLAN_FILTER
 v2: removed unused function ixgbe_is_vf()

 drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Wei Zhao - March 18, 2019, 3:05 a.m.
Acked-by: Wei Zhao <wei.zhao1@intel.com>


> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Harton
> Sent: Saturday, March 16, 2019 12:09 AM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> David Harton <dharton@cisco.com>
> Subject: [dpdk-dev] [PATCH v4] net/ixgbe: Restore vlan filter for ixgbevf
> 
> ixgbevf vlan strip and extend capabilities were removed when migrating to
> the bit flags implementation.
> 
> Restoring the capbility to enable the vlan strip offload at configuration time.
> 
> Fixes: ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\")
> Signed-off-by: David Harton <dharton@cisco.com>
> ---
> 
>  v4: fixed commit headline/log
>  v3: restored ixgbe_is_vf() and only restore VLAN_FILTER
>  v2: removed unused function ixgbe_is_vf()
> 
>  drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
> index e92a70fb3..e71d3c188 100644
> --- a/drivers/net/ixgbe/ixgbe_rxtx.c
> +++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> @@ -2853,14 +2853,14 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev
> *dev)
>  		   DEV_RX_OFFLOAD_TCP_CKSUM   |
>  		   DEV_RX_OFFLOAD_KEEP_CRC    |
>  		   DEV_RX_OFFLOAD_JUMBO_FRAME |
> +		   DEV_RX_OFFLOAD_VLAN_FILTER |
>  		   DEV_RX_OFFLOAD_SCATTER;
> 
>  	if (hw->mac.type == ixgbe_mac_82598EB)
>  		offloads |= DEV_RX_OFFLOAD_VLAN_STRIP;
> 
>  	if (ixgbe_is_vf(dev) == 0)
> -		offloads |= (DEV_RX_OFFLOAD_VLAN_FILTER |
> -			     DEV_RX_OFFLOAD_VLAN_EXTEND);
> +		offloads |= DEV_RX_OFFLOAD_VLAN_EXTEND;
> 
>  	/*
>  	 * RSC is only supported by 82599 and x540 PF devices in a non-SR-
> IOV
> --
> 2.19.1
Zhang Qi - March 18, 2019, 4:59 a.m.
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Monday, March 18, 2019 11:05 AM
> To: David Harton <dharton@cisco.com>; dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: RE: [dpdk-dev] [PATCH v4] net/ixgbe: Restore vlan filter for ixgbevf
> 
> Acked-by: Wei Zhao <wei.zhao1@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Harton
> > Sent: Saturday, March 16, 2019 12:09 AM
> > To: dev@dpdk.org
> > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Ananyev, Konstantin
> > <konstantin.ananyev@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> > David Harton <dharton@cisco.com>
> > Subject: [dpdk-dev] [PATCH v4] net/ixgbe: Restore vlan filter for
> > ixgbevf
> >
> > ixgbevf vlan strip and extend capabilities were removed when migrating
> > to the bit flags implementation.
> >
> > Restoring the capbility to enable the vlan strip offload at configuration time.
> >
> > Fixes: ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\")
> > Signed-off-by: David Harton <dharton@cisco.com>
> > ---
> >
> >  v4: fixed commit headline/log
> >  v3: restored ixgbe_is_vf() and only restore VLAN_FILTER
> >  v2: removed unused function ixgbe_is_vf()
> >
> >  drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c
> > b/drivers/net/ixgbe/ixgbe_rxtx.c index e92a70fb3..e71d3c188 100644
> > --- a/drivers/net/ixgbe/ixgbe_rxtx.c
> > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> > @@ -2853,14 +2853,14 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev
> > *dev)
> >  		   DEV_RX_OFFLOAD_TCP_CKSUM   |
> >  		   DEV_RX_OFFLOAD_KEEP_CRC    |
> >  		   DEV_RX_OFFLOAD_JUMBO_FRAME |
> > +		   DEV_RX_OFFLOAD_VLAN_FILTER |
> >  		   DEV_RX_OFFLOAD_SCATTER;
> >
> >  	if (hw->mac.type == ixgbe_mac_82598EB)
> >  		offloads |= DEV_RX_OFFLOAD_VLAN_STRIP;
> >
> >  	if (ixgbe_is_vf(dev) == 0)
> > -		offloads |= (DEV_RX_OFFLOAD_VLAN_FILTER |
> > -			     DEV_RX_OFFLOAD_VLAN_EXTEND);
> > +		offloads |= DEV_RX_OFFLOAD_VLAN_EXTEND;
> >
> >  	/*
> >  	 * RSC is only supported by 82599 and x540 PF devices in a non-SR-
> > IOV
> > --
> > 2.19.1

Patch

diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
index e92a70fb3..e71d3c188 100644
--- a/drivers/net/ixgbe/ixgbe_rxtx.c
+++ b/drivers/net/ixgbe/ixgbe_rxtx.c
@@ -2853,14 +2853,14 @@  ixgbe_get_rx_port_offloads(struct rte_eth_dev *dev)
 		   DEV_RX_OFFLOAD_TCP_CKSUM   |
 		   DEV_RX_OFFLOAD_KEEP_CRC    |
 		   DEV_RX_OFFLOAD_JUMBO_FRAME |
+		   DEV_RX_OFFLOAD_VLAN_FILTER |
 		   DEV_RX_OFFLOAD_SCATTER;
 
 	if (hw->mac.type == ixgbe_mac_82598EB)
 		offloads |= DEV_RX_OFFLOAD_VLAN_STRIP;
 
 	if (ixgbe_is_vf(dev) == 0)
-		offloads |= (DEV_RX_OFFLOAD_VLAN_FILTER |
-			     DEV_RX_OFFLOAD_VLAN_EXTEND);
+		offloads |= DEV_RX_OFFLOAD_VLAN_EXTEND;
 
 	/*
 	 * RSC is only supported by 82599 and x540 PF devices in a non-SR-IOV