Patchwork [v2,1/6] dt-bindings: connector: add optional properties for Type-B

login
register
mail settings
Submitter Chunfeng Yun
Date March 15, 2019, 7:38 a.m.
Message ID <1552635513-2378-2-git-send-email-chunfeng.yun@mediatek.com>
Download mbox | patch
Permalink /patch/749355/
State New
Headers show

Comments

Chunfeng Yun - March 15, 2019, 7:38 a.m.
Add id-gpios, vbus-gpios, vbus-supply and pinctrl properties for
usb-b-connector

Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
v2 changes:
  1. describe more clear for vbus-gpios and vbus-supply suggested by Hans
---
 .../devicetree/bindings/connector/usb-connector.txt      | 9 +++++++++
 1 file changed, 9 insertions(+)
Rob Herring - March 31, 2019, 6:40 a.m.
On Fri, Mar 15, 2019 at 03:38:28PM +0800, Chunfeng Yun wrote:
> Add id-gpios, vbus-gpios, vbus-supply and pinctrl properties for
> usb-b-connector
> 
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> v2 changes:
>   1. describe more clear for vbus-gpios and vbus-supply suggested by Hans
> ---
>  .../devicetree/bindings/connector/usb-connector.txt      | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/connector/usb-connector.txt b/Documentation/devicetree/bindings/connector/usb-connector.txt
> index a9a2f2fc44f2..1c4ed6c9afa8 100644
> --- a/Documentation/devicetree/bindings/connector/usb-connector.txt
> +++ b/Documentation/devicetree/bindings/connector/usb-connector.txt
> @@ -17,6 +17,15 @@ Optional properties:
>  - self-powered: Set this property if the usb device that has its own power
>    source.
>  
> +Optional properties for usb-b-connector:
> +- id-gpios: gpio for USB ID pin.
> +- vbus-gpios: gpio for USB VBUS pin, used to detect presence of VBUS 5V.
> +  see gpio/gpio.txt.

Please make it explicit that this is an input gpio. An output GPIO 
controlling a Vbus regulator should be modelled as a regulator.

> +- vbus-supply: a phandle to the regulator for USB VBUS if needed.
> +- pinctrl-names : a pinctrl state named "default" is optional
> +- pinctrl-0 : pin control group
> +  see pinctrl/pinctrl-bindings.txt
> +
>  Optional properties for usb-c-connector:
>  - power-role: should be one of "source", "sink" or "dual"(DRP) if typec
>    connector has power support.
> -- 
> 2.20.1
>
Chunfeng Yun - March 31, 2019, 12:45 p.m.
Hi Rob,
On Sun, 2019-03-31 at 01:40 -0500, Rob Herring wrote:
> On Fri, Mar 15, 2019 at 03:38:28PM +0800, Chunfeng Yun wrote:
> > Add id-gpios, vbus-gpios, vbus-supply and pinctrl properties for
> > usb-b-connector
> > 
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> > v2 changes:
> >   1. describe more clear for vbus-gpios and vbus-supply suggested by Hans
> > ---
> >  .../devicetree/bindings/connector/usb-connector.txt      | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/connector/usb-connector.txt b/Documentation/devicetree/bindings/connector/usb-connector.txt
> > index a9a2f2fc44f2..1c4ed6c9afa8 100644
> > --- a/Documentation/devicetree/bindings/connector/usb-connector.txt
> > +++ b/Documentation/devicetree/bindings/connector/usb-connector.txt
> > @@ -17,6 +17,15 @@ Optional properties:
> >  - self-powered: Set this property if the usb device that has its own power
> >    source.
> >  
> > +Optional properties for usb-b-connector:
> > +- id-gpios: gpio for USB ID pin.
> > +- vbus-gpios: gpio for USB VBUS pin, used to detect presence of VBUS 5V.
> > +  see gpio/gpio.txt.
> 
> Please make it explicit that this is an input gpio. An output GPIO 
> controlling a Vbus regulator should be modelled as a regulator.
Ok, thanks

> 
> > +- vbus-supply: a phandle to the regulator for USB VBUS if needed.
> > +- pinctrl-names : a pinctrl state named "default" is optional
> > +- pinctrl-0 : pin control group
> > +  see pinctrl/pinctrl-bindings.txt
> > +
> >  Optional properties for usb-c-connector:
> >  - power-role: should be one of "source", "sink" or "dual"(DRP) if typec
> >    connector has power support.
> > -- 
> > 2.20.1
> > 
>

Patch

diff --git a/Documentation/devicetree/bindings/connector/usb-connector.txt b/Documentation/devicetree/bindings/connector/usb-connector.txt
index a9a2f2fc44f2..1c4ed6c9afa8 100644
--- a/Documentation/devicetree/bindings/connector/usb-connector.txt
+++ b/Documentation/devicetree/bindings/connector/usb-connector.txt
@@ -17,6 +17,15 @@  Optional properties:
 - self-powered: Set this property if the usb device that has its own power
   source.
 
+Optional properties for usb-b-connector:
+- id-gpios: gpio for USB ID pin.
+- vbus-gpios: gpio for USB VBUS pin, used to detect presence of VBUS 5V.
+  see gpio/gpio.txt.
+- vbus-supply: a phandle to the regulator for USB VBUS if needed.
+- pinctrl-names : a pinctrl state named "default" is optional
+- pinctrl-0 : pin control group
+  see pinctrl/pinctrl-bindings.txt
+
 Optional properties for usb-c-connector:
 - power-role: should be one of "source", "sink" or "dual"(DRP) if typec
   connector has power support.