Patchwork [dpdk-dev,v3,1/8] net/ice: fix Tx function setting

login
register
mail settings
Submitter Wenzhuo Lu
Date March 15, 2019, 6:22 a.m.
Message ID <1552630975-62900-2-git-send-email-wenzhuo.lu@intel.com>
Download mbox | patch
Permalink /patch/749305/
State New
Headers show

Comments

Wenzhuo Lu - March 15, 2019, 6:22 a.m.
The TX setting functions is not called.

Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx")
Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
---
 drivers/net/ice/ice_ethdev.c | 1 +
 1 file changed, 1 insertion(+)
Ferruh Yigit - March 15, 2019, 5:52 p.m.
On 3/15/2019 6:22 AM, Wenzhuo Lu wrote:
> The TX setting functions is not called.
> 
> Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx")

Do we need stable@dpdk.org tag for this?

> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> ---
>  drivers/net/ice/ice_ethdev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
> index a23c63a..b804be1 100644
> --- a/drivers/net/ice/ice_ethdev.c
> +++ b/drivers/net/ice/ice_ethdev.c
> @@ -1741,6 +1741,7 @@ static int ice_init_rss(struct ice_pf *pf)
>  	}
>  
>  	ice_set_rx_function(dev);
> +	ice_set_tx_function(dev);
>  
>  	mask = ETH_VLAN_STRIP_MASK | ETH_VLAN_FILTER_MASK |
>  			ETH_VLAN_EXTEND_MASK;
>
Wenzhuo Lu - March 18, 2019, 1:08 a.m.
Hi Ferruh,

> -----Original Message-----

> From: Yigit, Ferruh

> Sent: Saturday, March 16, 2019 1:52 AM

> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; dev@dpdk.org

> Subject: Re: [dpdk-dev] [PATCH v3 1/8] net/ice: fix Tx function setting

> 

> On 3/15/2019 6:22 AM, Wenzhuo Lu wrote:

> > The TX setting functions is not called.

> >

> > Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx")

> 

> Do we need stable@dpdk.org tag for this?

This patch fixed a bug which is introduced in 19.02. That's why I think "stable" is not needed. Please let me know if I'm wrong. Thanks.
Ferruh Yigit - March 20, 2019, 5:22 p.m.
On 3/18/2019 1:08 AM, Lu, Wenzhuo wrote:
> Hi Ferruh,
> 
>> -----Original Message-----
>> From: Yigit, Ferruh
>> Sent: Saturday, March 16, 2019 1:52 AM
>> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; dev@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH v3 1/8] net/ice: fix Tx function setting
>>
>> On 3/15/2019 6:22 AM, Wenzhuo Lu wrote:
>>> The TX setting functions is not called.
>>>
>>> Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx")
>>
>> Do we need stable@dpdk.org tag for this?
> This patch fixed a bug which is introduced in 19.02. That's why I think "stable" is not needed. Please let me know if I'm wrong. Thanks.
> 

'stable' tag is not required if the commit you are fixing is not released yet,
it means it is in the current release, 19.05.
Otherwise 'stable' tag is required.
Wenzhuo Lu - March 21, 2019, 2:29 a.m.
Hi Ferruh,


> -----Original Message-----

> From: Yigit, Ferruh

> Sent: Thursday, March 21, 2019 1:22 AM

> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; dev@dpdk.org

> Subject: Re: [dpdk-dev] [PATCH v3 1/8] net/ice: fix Tx function setting

> 

> On 3/18/2019 1:08 AM, Lu, Wenzhuo wrote:

> > Hi Ferruh,

> >

> >> -----Original Message-----

> >> From: Yigit, Ferruh

> >> Sent: Saturday, March 16, 2019 1:52 AM

> >> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; dev@dpdk.org

> >> Subject: Re: [dpdk-dev] [PATCH v3 1/8] net/ice: fix Tx function

> >> setting

> >>

> >> On 3/15/2019 6:22 AM, Wenzhuo Lu wrote:

> >>> The TX setting functions is not called.

> >>>

> >>> Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx")

> >>

> >> Do we need stable@dpdk.org tag for this?

> > This patch fixed a bug which is introduced in 19.02. That's why I think

> "stable" is not needed. Please let me know if I'm wrong. Thanks.

> >

> 

> 'stable' tag is not required if the commit you are fixing is not released yet, it

> means it is in the current release, 19.05.

> Otherwise 'stable' tag is required.

Thanks. I'll add it.

Patch

diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index a23c63a..b804be1 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -1741,6 +1741,7 @@  static int ice_init_rss(struct ice_pf *pf)
 	}
 
 	ice_set_rx_function(dev);
+	ice_set_tx_function(dev);
 
 	mask = ETH_VLAN_STRIP_MASK | ETH_VLAN_FILTER_MASK |
 			ETH_VLAN_EXTEND_MASK;