Patchwork [dpdk-dev,v2] net/octeontx: fix vdev name

login
register
mail settings
Submitter Stephen Hemminger
Date March 13, 2019, 9:58 p.m.
Message ID <20190313215815.19629-1-stephen@networkplumber.org>
Download mbox | patch
Permalink /patch/748467/
State New
Headers show

Comments

Stephen Hemminger - March 13, 2019, 9:58 p.m.
The octeontx driver is creating vdev with name  "OCTEONTX_PMD"
which is an artifact from how RTE_PMD_REGISTER_VDEV arguments
work.

Change to use the same convention as all the other network
drivers ie "net_octeontx").

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Reviewed-by: Ramil Rosen <ramirose@gmail.com>
---
v2 - fix typo in commit message and name should be net_octeontx
     not net_octeon

 drivers/net/octeontx/octeontx_ethdev.h | 1 +
 1 file changed, 1 insertion(+)
Jerin Jacob Kollanukkaran - March 14, 2019, 3:35 p.m.
On Wed, 2019-03-13 at 14:58 -0700, Stephen Hemminger wrote:
> The octeontx driver is creating vdev with name  "OCTEONTX_PMD"

> which is an artifact from how RTE_PMD_REGISTER_VDEV arguments

> work.

> 

> Change to use the same convention as all the other network

> drivers ie "net_octeontx").

> 

> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

> Reviewed-by: Ramil Rosen <ramirose@gmail.com>

> ---


Acked-by: Jerin Jacob <jerinj@marvell.com>
Ferruh Yigit - March 19, 2019, 6:59 p.m.
On 3/14/2019 3:35 PM, Jerin Jacob Kollanukkaran wrote:
> On Wed, 2019-03-13 at 14:58 -0700, Stephen Hemminger wrote:
>> The octeontx driver is creating vdev with name  "OCTEONTX_PMD"
>> which is an artifact from how RTE_PMD_REGISTER_VDEV arguments
>> work.
>>
>> Change to use the same convention as all the other network
>> drivers ie "net_octeontx").
>>
>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>> Reviewed-by: Ramil Rosen <ramirose@gmail.com>
>> ---
> 
> Acked-by: Jerin Jacob <jerinj@marvell.com>
> 

Hi Jerin, Stephen,

Can you please provide fixes line, (which commit broke the pmd name)?

Thanks,
ferruh
Stephen Hemminger - March 19, 2019, 10:19 p.m.
On Tue, 19 Mar 2019 18:59:21 +0000
Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> On 3/14/2019 3:35 PM, Jerin Jacob Kollanukkaran wrote:
> > On Wed, 2019-03-13 at 14:58 -0700, Stephen Hemminger wrote:  
> >> The octeontx driver is creating vdev with name  "OCTEONTX_PMD"
> >> which is an artifact from how RTE_PMD_REGISTER_VDEV arguments
> >> work.
> >>
> >> Change to use the same convention as all the other network
> >> drivers ie "net_octeontx").
> >>
> >> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> >> Reviewed-by: Ramil Rosen <ramirose@gmail.com>
> >> ---  
> > 
> > Acked-by: Jerin Jacob <jerinj@marvell.com>
> >   
> 
> Hi Jerin, Stephen,
> 
> Can you please provide fixes line, (which commit broke the pmd name)?

It goes all the way back to original submission:

Fixes: f7be70e5130e ("net/octeontx: add net device probe and remove")
Ferruh Yigit - March 20, 2019, 3:09 p.m.
On 3/19/2019 10:19 PM, Stephen Hemminger wrote:
> On Tue, 19 Mar 2019 18:59:21 +0000
> Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> 
>> On 3/14/2019 3:35 PM, Jerin Jacob Kollanukkaran wrote:
>>> On Wed, 2019-03-13 at 14:58 -0700, Stephen Hemminger wrote:  
>>>> The octeontx driver is creating vdev with name  "OCTEONTX_PMD"
>>>> which is an artifact from how RTE_PMD_REGISTER_VDEV arguments
>>>> work.
>>>>
>>>> Change to use the same convention as all the other network
>>>> drivers ie "net_octeontx").
>>>>
>>>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>>>> Reviewed-by: Ramil Rosen <ramirose@gmail.com>
>>>> ---  
>>>
>>> Acked-by: Jerin Jacob <jerinj@marvell.com>
>>>   
>>
>> Hi Jerin, Stephen,
>>
>> Can you please provide fixes line, (which commit broke the pmd name)?
> 
> It goes all the way back to original submission:
> 
> Fixes: f7be70e5130e ("net/octeontx: add net device probe and remove")
> 

Indeed, I was assuming it has been broken somewhere on the way, but is seems no.

Applied to dpdk-next-net/master, thanks.

Patch

diff --git a/drivers/net/octeontx/octeontx_ethdev.h b/drivers/net/octeontx/octeontx_ethdev.h
index 920f6f89b882..2a4a08afcc7f 100644
--- a/drivers/net/octeontx/octeontx_ethdev.h
+++ b/drivers/net/octeontx/octeontx_ethdev.h
@@ -21,6 +21,7 @@ 
 #include "base/octeontx_pkovf.h"
 #include "base/octeontx_io.h"
 
+#define OCTEONTX_PMD				net_octeontx
 #define OCTEONTX_VDEV_DEFAULT_MAX_NR_PORT	12
 #define OCTEONTX_VDEV_NR_PORT_ARG		("nr_port")
 #define OCTEONTX_MAX_NAME_LEN			32