Patchwork [dpdk-dev,1/2] examples/ethtool: remove query of default config

login
register
mail settings
Submitter Thomas Monjalon
Date March 13, 2019, 10:09 a.m.
Message ID <20190313100910.31260-2-thomas@monjalon.net>
Download mbox | patch
Permalink /patch/747995/
State New
Headers show

Comments

Thomas Monjalon - March 13, 2019, 10:09 a.m.
The default config is used if the setup parameter is NULL.
No need to query the default config with rte_eth_dev_info_get().
The function call will be removed with another useless info.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 examples/ethtool/ethtool-app/main.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
Bruce Richardson - March 13, 2019, 10:32 a.m.
On Wed, Mar 13, 2019 at 11:09:09AM +0100, Thomas Monjalon wrote:
> The default config is used if the setup parameter is NULL.
> No need to query the default config with rte_eth_dev_info_get().
> The function call will be removed with another useless info.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Rami Rosen - March 13, 2019, 5:41 p.m.
On Wed, Mar 13, 2019 at 11:09:09AM +0100, Thomas Monjalon wrote:
> > The default config is used if the setup parameter is NULL.
> > No need to query the default config with rte_eth_dev_info_get().
> > The function call will be removed with another useless info.
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>

Reviewed-by: Rami Rosen <ramirose@gmail.com>

Patch

diff --git a/examples/ethtool/ethtool-app/main.c b/examples/ethtool/ethtool-app/main.c
index dc93adfe3..e23d3afd2 100644
--- a/examples/ethtool/ethtool-app/main.c
+++ b/examples/ethtool/ethtool-app/main.c
@@ -95,7 +95,6 @@  static void setup_ports(struct app_config *app_cfg, int cnt_ports)
 	char str_name[16];
 	uint16_t nb_rxd = PORT_RX_QUEUE_SIZE;
 	uint16_t nb_txd = PORT_TX_QUEUE_SIZE;
-	struct rte_eth_txconf txconf;
 
 	memset(&cfg_port, 0, sizeof(cfg_port));
 	cfg_port.txmode.mq_mode = ETH_MQ_TX_NONE;
@@ -140,10 +139,9 @@  static void setup_ports(struct app_config *app_cfg, int cnt_ports)
 			rte_exit(EXIT_FAILURE,
 				 "rte_eth_rx_queue_setup failed"
 				);
-		txconf = dev_info.default_txconf;
 		if (rte_eth_tx_queue_setup(
 			    idx_port, 0, nb_txd,
-			    rte_eth_dev_socket_id(idx_port), &txconf) < 0)
+			    rte_eth_dev_socket_id(idx_port), NULL) < 0)
 			rte_exit(EXIT_FAILURE,
 				 "rte_eth_tx_queue_setup failed"
 				);