Patchwork [dpdk-dev] net/octeontx: fix vdev name

login
register
mail settings
Submitter Stephen Hemminger
Date March 12, 2019, 7:27 p.m.
Message ID <20190312192703.18554-1-stephen@networkplumber.org>
Download mbox | patch
Permalink /patch/747643/
State New
Headers show

Comments

Stephen Hemminger - March 12, 2019, 7:27 p.m.
The octeontx driver is creating vdev with name  "OCTEONTX_PMD"
which is an artifact from how RTE_PMD_REGISTER_VDEV arguments
work.

Change to use the same convention as all the other network
driverse ("net_octeontx").

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/octeontx/octeontx_ethdev.h | 1 +
 1 file changed, 1 insertion(+)
Rami Rosen - March 13, 2019, 7:35 p.m.
> The octeontx driver is creating vdev with name  "OCTEONTX_PMD"
> which is an artifact from how RTE_PMD_REGISTER_VDEV arguments
> work.
>
> Change to use the same convention as all the other network
> driverse ("net_octeontx").
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>


1. Actuaully in the patch itself it is:

+#define OCTEONTX_PMD                           net_octeon

Shouldn't it be "net_octeontx" as in the commit log ?

2. Typo in commit log: driverse->drivers

Reviewed-by: Rami Rosen <ramirose@gmail.com>

Patch

diff --git a/drivers/net/octeontx/octeontx_ethdev.h b/drivers/net/octeontx/octeontx_ethdev.h
index 920f6f89b882..f21652c9a6c8 100644
--- a/drivers/net/octeontx/octeontx_ethdev.h
+++ b/drivers/net/octeontx/octeontx_ethdev.h
@@ -21,6 +21,7 @@ 
 #include "base/octeontx_pkovf.h"
 #include "base/octeontx_io.h"
 
+#define OCTEONTX_PMD				net_octeon
 #define OCTEONTX_VDEV_DEFAULT_MAX_NR_PORT	12
 #define OCTEONTX_VDEV_NR_PORT_ARG		("nr_port")
 #define OCTEONTX_MAX_NAME_LEN			32