Patchwork [7/8] usb: dwc2: Add Amlogic G12A DWC2 Params

login
register
mail settings
Submitter Neil Armstrong
Date Feb. 12, 2019, 3:14 p.m.
Message ID <20190212151413.24632-8-narmstrong@baylibre.com>
Download mbox | patch
Permalink /patch/724007/
State New
Headers show

Comments

Neil Armstrong - Feb. 12, 2019, 3:14 p.m.
This patchs sets the params for the DWC2 Controller found in the
Amlogic G12A SoC family.

It mainly sets the settings reported incorrect by the driver,
leaving the remaining detected automatically by the driver and
provided by the DT node.

Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 drivers/usb/dwc2/params.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)
Minas Harutyunyan - April 9, 2019, 9:31 a.m.
> This patchs sets the params for the DWC2 Controller found in the Amlogic G12A SoC family.
> 
> It mainly sets the settings reported incorrect by the driver, leaving the remaining detected automatically by the driver and provided by the DT node.
> 
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>

Acked-by: Minas Harutyunyan <hminas@synopsys.com>

> ---
>  drivers/usb/dwc2/params.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c index 24ff5f21cb25..442113246cba 100644
> --- a/drivers/usb/dwc2/params.c
> +++ b/drivers/usb/dwc2/params.c
> @@ -121,6 +121,16 @@ static void dwc2_set_amlogic_params(struct dwc2_hsotg *hsotg)
>  	p->power_down = DWC2_POWER_DOWN_PARAM_NONE;  }
>  
> +static void dwc2_set_amlogic_g12a_params(struct dwc2_hsotg *hsotg) {
> +	struct dwc2_core_params *p = &hsotg->params;
> +
> +	p->lpm = false;
> +	p->lpm_clock_gating = false;
> +	p->besl = false;
> +	p->hird_threshold_en = false;
> +}
> +
>  static void dwc2_set_amcc_params(struct dwc2_hsotg *hsotg)  {
>  	struct dwc2_core_params *p = &hsotg->params; @@ -167,6 +177,8 @@ const struct of_device_id dwc2_of_match_table[] = {
>  	  .data = dwc2_set_amlogic_params },
>  	{ .compatible = "amlogic,meson-gxbb-usb",
>  	  .data = dwc2_set_amlogic_params },
> +	{ .compatible = "amlogic,meson-g12a-usb",
> +	  .data = dwc2_set_amlogic_g12a_params },
>  	{ .compatible = "amcc,dwc-otg", .data = dwc2_set_amcc_params },
>  	{ .compatible = "st,stm32f4x9-fsotg",
>  	  .data = dwc2_set_stm32f4x9_fsotg_params },
> --
> 2.20.1
>

Patch

diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
index 24ff5f21cb25..442113246cba 100644
--- a/drivers/usb/dwc2/params.c
+++ b/drivers/usb/dwc2/params.c
@@ -121,6 +121,16 @@  static void dwc2_set_amlogic_params(struct dwc2_hsotg *hsotg)
 	p->power_down = DWC2_POWER_DOWN_PARAM_NONE;
 }
 
+static void dwc2_set_amlogic_g12a_params(struct dwc2_hsotg *hsotg)
+{
+	struct dwc2_core_params *p = &hsotg->params;
+
+	p->lpm = false;
+	p->lpm_clock_gating = false;
+	p->besl = false;
+	p->hird_threshold_en = false;
+}
+
 static void dwc2_set_amcc_params(struct dwc2_hsotg *hsotg)
 {
 	struct dwc2_core_params *p = &hsotg->params;
@@ -167,6 +177,8 @@  const struct of_device_id dwc2_of_match_table[] = {
 	  .data = dwc2_set_amlogic_params },
 	{ .compatible = "amlogic,meson-gxbb-usb",
 	  .data = dwc2_set_amlogic_params },
+	{ .compatible = "amlogic,meson-g12a-usb",
+	  .data = dwc2_set_amlogic_g12a_params },
 	{ .compatible = "amcc,dwc-otg", .data = dwc2_set_amcc_params },
 	{ .compatible = "st,stm32f4x9-fsotg",
 	  .data = dwc2_set_stm32f4x9_fsotg_params },