Patchwork [RFC,1/6] mfd: Support for Ettus Research E31x devices PMU

login
register
mail settings
Submitter Virendra Kakade
Date Feb. 12, 2019, 1:01 a.m.
Message ID <20190212010143.3729-2-virendra.kakade@ni.com>
Download mbox | patch
Permalink /patch/723459/
State New
Headers show

Comments

Virendra Kakade - Feb. 12, 2019, 1:01 a.m.
Document bindings for E31x device PMU MFD driver.

Signed-off-by: Virendra Kakade <virendra.kakade@ni.com>
---
 Documentation/devicetree/bindings/mfd/e31x-pmu.txt | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/e31x-pmu.txt
Moritz Fischer - Feb. 12, 2019, 10:51 a.m.
Hi Virendra,

On Mon, Feb 11, 2019 at 5:02 PM Virendra Kakade <virendra.kakade@ni.com> wrote:
>
> Document bindings for E31x device PMU MFD driver.
>
> Signed-off-by: Virendra Kakade <virendra.kakade@ni.com>
> ---
>  Documentation/devicetree/bindings/mfd/e31x-pmu.txt | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/e31x-pmu.txt
>
> diff --git a/Documentation/devicetree/bindings/mfd/e31x-pmu.txt b/Documentation/devicetree/bindings/mfd/e31x-pmu.txt
> new file mode 100644
> index 000000000000..ebb5625f6c74
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/e31x-pmu.txt
> @@ -0,0 +1,14 @@
> +Ettus Research/National Instruments E31x PMU MFD driver
> +
> +Required properties:
> +- compatible : Must be "ni,e31x-pmu"
> +- regmap     : Must be <&regmapnode>
> +
> +Example:
> +
> +pmu {
> +       compatible = "ni,e31x-pmu";
> +       regmap = <&devctrl>;
> +       status = "okay";

Please drop this.
>
> +};
> +
> --
> 2.17.1
>

Your binding patches should have "dt-bindings: ... " in the commit message.

Please fix that when you resubmit your series.

Cheers,
Moritz
Lee Jones - Feb. 14, 2019, 9:23 a.m.
On Mon, 11 Feb 2019, Virendra Kakade wrote:

> Document bindings for E31x device PMU MFD driver.
> 
> Signed-off-by: Virendra Kakade <virendra.kakade@ni.com>
> ---
>  Documentation/devicetree/bindings/mfd/e31x-pmu.txt | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/e31x-pmu.txt
> 
> diff --git a/Documentation/devicetree/bindings/mfd/e31x-pmu.txt b/Documentation/devicetree/bindings/mfd/e31x-pmu.txt
> new file mode 100644
> index 000000000000..ebb5625f6c74
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/e31x-pmu.txt
> @@ -0,0 +1,14 @@
> +Ettus Research/National Instruments E31x PMU MFD driver

Please expand on what PMU is.

MFD is a Linuxisum and has no place in the description.

You can supplement it with "parent device" or some such.

> +Required properties:
> +- compatible : Must be "ni,e31x-pmu"
> +- regmap     : Must be <&regmapnode>
> +
> +Example:
> +
> +pmu {
> +	compatible = "ni,e31x-pmu";

No address?

> +	regmap = <&devctrl>;
> +	status = "okay";

Not required in DT documentation.

> +};
> +

Patch

diff --git a/Documentation/devicetree/bindings/mfd/e31x-pmu.txt b/Documentation/devicetree/bindings/mfd/e31x-pmu.txt
new file mode 100644
index 000000000000..ebb5625f6c74
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/e31x-pmu.txt
@@ -0,0 +1,14 @@ 
+Ettus Research/National Instruments E31x PMU MFD driver
+
+Required properties:
+- compatible : Must be "ni,e31x-pmu"
+- regmap     : Must be <&regmapnode>
+
+Example:
+
+pmu {
+	compatible = "ni,e31x-pmu";
+	regmap = <&devctrl>;
+	status = "okay";
+};
+