Patchwork isdn: i4l: isdn_tty: Mark expected switch fall-through

login
register
mail settings
Submitter Gustavo A. R. Silva
Date Feb. 11, 2019, 10:38 p.m.
Message ID <20190211223821.GA13158@embeddedor>
Download mbox | patch
Permalink /patch/723369/
State New
Headers show

Comments

Gustavo A. R. Silva - Feb. 11, 2019, 10:38 p.m.
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.

This patch fixes the following warnings:

drivers/isdn/i4l/isdn_tty.c: In function ‘isdn_tty_edit_at’:
drivers/isdn/i4l/isdn_tty.c:3644:18: warning: this statement may fall through [-Wimplicit-fallthrough=]
       m->mdmcmdl = 0;
       ~~~~~~~~~~~^~~
drivers/isdn/i4l/isdn_tty.c:3646:5: note: here
     case 0:
     ^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

Notice that, in this particular case, the code comment is modified
in accordance with what GCC is expecting to find.

This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
 drivers/isdn/i4l/isdn_tty.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
David Miller - Feb. 12, 2019, 6:29 p.m.
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>

Date: Mon, 11 Feb 2019 16:38:21 -0600

> In preparation to enabling -Wimplicit-fallthrough, mark switch

> cases where we are expecting to fall through.

> 

> This patch fixes the following warnings:

> 

> drivers/isdn/i4l/isdn_tty.c: In function ‘isdn_tty_edit_at’:

> drivers/isdn/i4l/isdn_tty.c:3644:18: warning: this statement may fall through [-Wimplicit-fallthrough=]

>        m->mdmcmdl = 0;

>        ~~~~~~~~~~~^~~

> drivers/isdn/i4l/isdn_tty.c:3646:5: note: here

>      case 0:

>      ^~~~

> 

> Warning level 3 was used: -Wimplicit-fallthrough=3

> 

> Notice that, in this particular case, the code comment is modified

> in accordance with what GCC is expecting to find.

> 

> This patch is part of the ongoing efforts to enable

> -Wimplicit-fallthrough.

> 

> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>


Applied.
Gustavo A. R. Silva - Feb. 12, 2019, 9:32 p.m.
Thanks, Dave.

--
Gustavo

On 2/12/19 12:29 PM, David Miller wrote:
> From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
> Date: Mon, 11 Feb 2019 16:38:21 -0600
> 
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warnings:
>>
>> drivers/isdn/i4l/isdn_tty.c: In function ‘isdn_tty_edit_at’:
>> drivers/isdn/i4l/isdn_tty.c:3644:18: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>        m->mdmcmdl = 0;
>>        ~~~~~~~~~~~^~~
>> drivers/isdn/i4l/isdn_tty.c:3646:5: note: here
>>      case 0:
>>      ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> Notice that, in this particular case, the code comment is modified
>> in accordance with what GCC is expecting to find.
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> 
> Applied.
>

Patch

diff --git a/drivers/isdn/i4l/isdn_tty.c b/drivers/isdn/i4l/isdn_tty.c
index dc1cded716c1..43700fc19a31 100644
--- a/drivers/isdn/i4l/isdn_tty.c
+++ b/drivers/isdn/i4l/isdn_tty.c
@@ -3642,7 +3642,7 @@  isdn_tty_edit_at(const char *p, int count, modem_info *info)
 						break;
 					} else
 						m->mdmcmdl = 0;
-					/* Fall through, check for 'A' */
+					/* Fall through - check for 'A' */
 				case 0:
 					if (c == 'A') {
 						m->mdmcmd[m->mdmcmdl] = c;