Patchwork isdn_v110: mark expected switch fall-through

login
register
mail settings
Submitter Gustavo A. R. Silva
Date Feb. 11, 2019, 10:42 p.m.
Message ID <20190211224237.GA29262@embeddedor>
Download mbox | patch
Permalink /patch/723351/
State New
Headers show

Comments

Gustavo A. R. Silva - Feb. 11, 2019, 10:42 p.m.
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.

This patch fixes the following warnings:

drivers/isdn/i4l/isdn_v110.c: In function ‘EncodeMatrix’:
drivers/isdn/i4l/isdn_v110.c:353:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
    if (line >= mlen) {
       ^
drivers/isdn/i4l/isdn_v110.c:358:3: note: here
   case 128:
   ^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

Notice that, in this particular case, the code comment is modified
in accordance with what GCC is expecting to find.

This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
 drivers/isdn/i4l/isdn_v110.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
David Miller - Feb. 12, 2019, 6:29 p.m.
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>

Date: Mon, 11 Feb 2019 16:42:37 -0600

> In preparation to enabling -Wimplicit-fallthrough, mark switch

> cases where we are expecting to fall through.

> 

> This patch fixes the following warnings:

> 

> drivers/isdn/i4l/isdn_v110.c: In function ‘EncodeMatrix’:

> drivers/isdn/i4l/isdn_v110.c:353:7: warning: this statement may fall through [-Wimplicit-fallthrough=]

>     if (line >= mlen) {

>        ^

> drivers/isdn/i4l/isdn_v110.c:358:3: note: here

>    case 128:

>    ^~~~

> 

> Warning level 3 was used: -Wimplicit-fallthrough=3

> 

> Notice that, in this particular case, the code comment is modified

> in accordance with what GCC is expecting to find.

> 

> This patch is part of the ongoing efforts to enable

> -Wimplicit-fallthrough.

> 

> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>


Applied.

Patch

diff --git a/drivers/isdn/i4l/isdn_v110.c b/drivers/isdn/i4l/isdn_v110.c
index 2a5f6668756c..d11fe76f138f 100644
--- a/drivers/isdn/i4l/isdn_v110.c
+++ b/drivers/isdn/i4l/isdn_v110.c
@@ -354,7 +354,7 @@  EncodeMatrix(unsigned char *buf, int len, unsigned char *m, int mlen)
 				printk(KERN_WARNING "isdn_v110 (EncodeMatrix): buffer full!\n");
 				return line;
 			}
-			/* else: fall through */
+			/* fall through */
 		case 128:
 			m[line] = 128;	/* leftmost -> set byte to 1000000 */
 			mbit = 64;	/* current bit in the matrix line */