Patchwork ser_gigaset: mark expected switch fall-through

login
register
mail settings
Submitter Gustavo A. R. Silva
Date Feb. 11, 2019, 10:34 p.m.
Message ID <20190211223444.GA29517@embeddedor>
Download mbox | patch
Permalink /patch/723347/
State New
Headers show

Comments

Gustavo A. R. Silva - Feb. 11, 2019, 10:34 p.m.
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.

This patch fixes the following warning:

drivers/isdn/gigaset/ser-gigaset.c: In function ‘gigaset_tty_ioctl’:
drivers/isdn/gigaset/ser-gigaset.c:627:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
   switch (arg) {
   ^~~~~~
drivers/isdn/gigaset/ser-gigaset.c:638:2: note: here
  default:
  ^~~~~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

Notice that, in this particular case, the code comment is modified
in accordance with what GCC is expecting to find.

This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
 drivers/isdn/gigaset/ser-gigaset.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Paul Bolle - Feb. 12, 2019, 8:45 a.m.
Gustavo A. R. Silva schreef op ma 11-02-2019 om 16:34 [-0600]:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
> 
> This patch fixes the following warning:
> 
> drivers/isdn/gigaset/ser-gigaset.c: In function ‘gigaset_tty_ioctl’:
> drivers/isdn/gigaset/ser-gigaset.c:627:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    switch (arg) {
>    ^~~~~~
> drivers/isdn/gigaset/ser-gigaset.c:638:2: note: here
>   default:
>   ^~~~~~~
> 
> Warning level 3 was used: -Wimplicit-fallthrough=3
> 
> Notice that, in this particular case, the code comment is modified
> in accordance with what GCC is expecting to find.
> 
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Acked-by: Paul Bolle <pebolle@tiscali.nl>

Thanks,


Paul Bolle
Gustavo A. R. Silva - Feb. 12, 2019, 2:58 p.m.
On 2/12/19 2:45 AM, Paul Bolle wrote:
> Gustavo A. R. Silva schreef op ma 11-02-2019 om 16:34 [-0600]:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> drivers/isdn/gigaset/ser-gigaset.c: In function ‘gigaset_tty_ioctl’:
>> drivers/isdn/gigaset/ser-gigaset.c:627:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>    switch (arg) {
>>    ^~~~~~
>> drivers/isdn/gigaset/ser-gigaset.c:638:2: note: here
>>   default:
>>   ^~~~~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> Notice that, in this particular case, the code comment is modified
>> in accordance with what GCC is expecting to find.
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> 
> Acked-by: Paul Bolle <pebolle@tiscali.nl>
> 

Thanks, Paul.

--
Gustavo
David Miller - Feb. 12, 2019, 6:29 p.m.
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>

Date: Mon, 11 Feb 2019 16:34:44 -0600

> In preparation to enabling -Wimplicit-fallthrough, mark switch

> cases where we are expecting to fall through.

> 

> This patch fixes the following warning:

> 

> drivers/isdn/gigaset/ser-gigaset.c: In function ‘gigaset_tty_ioctl’:

> drivers/isdn/gigaset/ser-gigaset.c:627:3: warning: this statement may fall through [-Wimplicit-fallthrough=]

>    switch (arg) {

>    ^~~~~~

> drivers/isdn/gigaset/ser-gigaset.c:638:2: note: here

>   default:

>   ^~~~~~~

> 

> Warning level 3 was used: -Wimplicit-fallthrough=3

> 

> Notice that, in this particular case, the code comment is modified

> in accordance with what GCC is expecting to find.

> 

> This patch is part of the ongoing efforts to enable

> -Wimplicit-fallthrough.

> 

> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>


Applied.

Patch

diff --git a/drivers/isdn/gigaset/ser-gigaset.c b/drivers/isdn/gigaset/ser-gigaset.c
index ab0b63a4d045..e1de8b1a1001 100644
--- a/drivers/isdn/gigaset/ser-gigaset.c
+++ b/drivers/isdn/gigaset/ser-gigaset.c
@@ -633,7 +633,7 @@  gigaset_tty_ioctl(struct tty_struct *tty, struct file *file,
 			flush_send_queue(cs);
 			break;
 		}
-		/* Pass through */
+		/* fall through */
 
 	default:
 		/* pass through to underlying serial device */