Patchwork [dpdk-dev] test: fix broken "make test"

login
register
mail settings
Submitter Rami Rosen
Date Feb. 11, 2019, 6:38 p.m.
Message ID <20190211183859.12314-1-ramirose@gmail.com>
Download mbox | patch
Permalink /patch/723243/
State New
Headers show

Comments

Rami Rosen - Feb. 11, 2019, 6:38 p.m.
This patch fixes a broken build; when running
make test
we get the following error:
...
Traceback (most recent call last):
  File "/work/src/dpdk-19.02/test/test/autotest.py", line 49, in <module>
    num_fails = runner.run_all_tests()
  File "/work/src/dpdk-19.02/test/test/autotest_runner.py", line 345, in
run_all_tests
    self.parallel_tests)
  File "/work/src/dpdk-19.02/test/test/autotest_runner.py", line 264, in
__filter_test
    test_cmd = test["Command"]
KeyError: 'Command'
...
The reason is that the pdump autotest entry uses "Comamnd"
instead of "Command"; this patch fixes it.

Bugzilla ID: 205
Fixes: 086eb64db39e ("test/pdump: add unit test for pdump library")
Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
 test/test/autotest_data.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Ferruh Yigit - Feb. 12, 2019, 9:36 a.m.
On 2/11/2019 6:38 PM, Rami Rosen wrote:
> This patch fixes a broken build; when running
> make test
> we get the following error:
> ...
> Traceback (most recent call last):
>   File "/work/src/dpdk-19.02/test/test/autotest.py", line 49, in <module>
>     num_fails = runner.run_all_tests()
>   File "/work/src/dpdk-19.02/test/test/autotest_runner.py", line 345, in
> run_all_tests
>     self.parallel_tests)
>   File "/work/src/dpdk-19.02/test/test/autotest_runner.py", line 264, in
> __filter_test
>     test_cmd = test["Command"]
> KeyError: 'Command'
> ...
> The reason is that the pdump autotest entry uses "Comamnd"
> instead of "Command"; this patch fixes it.
> 
> Bugzilla ID: 205
> Fixes: 086eb64db39e ("test/pdump: add unit test for pdump library")
> Signed-off-by: Rami Rosen <ramirose@gmail.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Good catch! But it seems 19.02 released autotest broken, so this needs to be
backported to 19.02:

Cc: stable@dpdk.org


Thomas,
What do you think adding autotest into DPDK community lab testing? I will bring
the the suggestion in next meeting.
David Marchand - Feb. 12, 2019, 9:59 a.m.
On Tue, Feb 12, 2019 at 10:36 AM Ferruh Yigit <ferruh.yigit@intel.com>
wrote:

> Good catch! But it seems 19.02 released autotest broken, so this needs to
> be
> backported to 19.02:
>
> Cc: stable@dpdk.org
>
>
> Thomas,
> What do you think adding autotest into DPDK community lab testing? I will
> bring
> the the suggestion in next meeting.
>

+1.
Thomas Monjalon - Feb. 12, 2019, 11:24 a.m.
12/02/2019 10:36, Ferruh Yigit:
> On 2/11/2019 6:38 PM, Rami Rosen wrote:
> > This patch fixes a broken build; when running
> > make test
> > we get the following error:
> > ...
> > Traceback (most recent call last):
> >   File "/work/src/dpdk-19.02/test/test/autotest.py", line 49, in <module>
> >     num_fails = runner.run_all_tests()
> >   File "/work/src/dpdk-19.02/test/test/autotest_runner.py", line 345, in
> > run_all_tests
> >     self.parallel_tests)
> >   File "/work/src/dpdk-19.02/test/test/autotest_runner.py", line 264, in
> > __filter_test
> >     test_cmd = test["Command"]
> > KeyError: 'Command'
> > ...
> > The reason is that the pdump autotest entry uses "Comamnd"
> > instead of "Command"; this patch fixes it.
> > 
> > Bugzilla ID: 205
> > Fixes: 086eb64db39e ("test/pdump: add unit test for pdump library")
> > Signed-off-by: Rami Rosen <ramirose@gmail.com>
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Good catch! But it seems 19.02 released autotest broken, so this needs to be
> backported to 19.02:
> 
> Cc: stable@dpdk.org

Applied, thanks


> Thomas,
> What do you think adding autotest into DPDK community lab testing? I will bring
> the the suggestion in next meeting.

Yes, sure.
It has already been discussed but no task was created:
	https://bugs.dpdk.org/buglist.cgi?product=lab
Let's follow-up in next meeting.
Ferruh Yigit - Feb. 12, 2019, 5:52 p.m.
On 2/12/2019 11:24 AM, Thomas Monjalon wrote:
> 12/02/2019 10:36, Ferruh Yigit:
>> On 2/11/2019 6:38 PM, Rami Rosen wrote:
>>> This patch fixes a broken build; when running
>>> make test
>>> we get the following error:
>>> ...
>>> Traceback (most recent call last):
>>>   File "/work/src/dpdk-19.02/test/test/autotest.py", line 49, in <module>
>>>     num_fails = runner.run_all_tests()
>>>   File "/work/src/dpdk-19.02/test/test/autotest_runner.py", line 345, in
>>> run_all_tests
>>>     self.parallel_tests)
>>>   File "/work/src/dpdk-19.02/test/test/autotest_runner.py", line 264, in
>>> __filter_test
>>>     test_cmd = test["Command"]
>>> KeyError: 'Command'
>>> ...
>>> The reason is that the pdump autotest entry uses "Comamnd"
>>> instead of "Command"; this patch fixes it.
>>>
>>> Bugzilla ID: 205
>>> Fixes: 086eb64db39e ("test/pdump: add unit test for pdump library")
>>> Signed-off-by: Rami Rosen <ramirose@gmail.com>
>>
>> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>
>> Good catch! But it seems 19.02 released autotest broken, so this needs to be
>> backported to 19.02:
>>
>> Cc: stable@dpdk.org
> 
> Applied, thanks
> 
> 
>> Thomas,
>> What do you think adding autotest into DPDK community lab testing? I will bring
>> the the suggestion in next meeting.
> 
> Yes, sure.
> It has already been discussed but no task was created:
> 	https://bugs.dpdk.org/buglist.cgi?product=lab
> Let's follow-up in next meeting.

It has been discussed again, and following task created for lab:
https://bugs.dpdk.org/show_bug.cgi?id=212

Patch

diff --git a/test/test/autotest_data.py b/test/test/autotest_data.py
index 948a625b5..5f87bb94d 100644
--- a/test/test/autotest_data.py
+++ b/test/test/autotest_data.py
@@ -508,7 +508,7 @@ 
     },
     {
         "Name":    "Pdump autotest",
-        "Comamnd": "pdump_autotest",
+        "Command": "pdump_autotest",
         "Func":    default_autotest,
         "Report":  None,
     },