Patchwork [V1,net,2/2] net: ena: update driver version from 2.0.2 to 2.0.3

login
register
mail settings
Submitter akiyano@amazon.com
Date Feb. 11, 2019, 5:17 p.m.
Message ID <1549905464-13758-3-git-send-email-akiyano@amazon.com>
Download mbox | patch
Permalink /patch/723169/
State New
Headers show

Comments

akiyano@amazon.com - Feb. 11, 2019, 5:17 p.m.
From: Arthur Kiyanovski <akiyano@amazon.com>

Update driver version due to bug fix.

Signed-off-by: Arthur Kiyanovski <akiyano@amazon.com>
---
 drivers/net/ethernet/amazon/ena/ena_netdev.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Moritz Fischer - Feb. 12, 2019, 11:12 a.m.
Hi Arthur,

On Mon, Feb 11, 2019 at 9:19 AM <akiyano@amazon.com> wrote:
>
> From: Arthur Kiyanovski <akiyano@amazon.com>
>
> Update driver version due to bug fix.

Wouldn't you want to do this atomically with the actual fix in one commit?

Thanks,
Moritz
akiyano@amazon.com - Feb. 12, 2019, 11:42 a.m.
Hi Moritz,

> -----Original Message-----

> From: Moritz Fischer <moritz.fischer@ettus.com>

> Subject: Re: [PATCH V1 net 2/2] net: ena: update driver version from 2.0.2 to

> 2.0.3

> 

> Hi Arthur,

> 

> On Mon, Feb 11, 2019 at 9:19 AM <akiyano@amazon.com> wrote:

> >

> > From: Arthur Kiyanovski <akiyano@amazon.com>

> >

> > Update driver version due to bug fix.

> 

> Wouldn't you want to do this atomically with the actual fix in one commit?

> 

> Thanks,

> Moritz


Thanks for the feedback.
I don't want to add the version to the fix.
Version 2.0.3 includes all of its content that came before this fix, including features.
Fixes are cherry-picked to older driver versions automatically using the "Fixes:" directive.
If I add the version change to the fix, older driver versions that get this fix will become version 2.0.3, which is incorrect feature-wise.

Thanks,
Arthur
Andrew Lunn - Feb. 12, 2019, 1:11 p.m.
On Tue, Feb 12, 2019 at 11:42:31AM +0000, Kiyanovski, Arthur wrote:
> Hi Moritz,
> 
> > -----Original Message-----
> > From: Moritz Fischer <moritz.fischer@ettus.com>
> > Subject: Re: [PATCH V1 net 2/2] net: ena: update driver version from 2.0.2 to
> > 2.0.3
> > 
> > Hi Arthur,
> > 
> > On Mon, Feb 11, 2019 at 9:19 AM <akiyano@amazon.com> wrote:
> > >
> > > From: Arthur Kiyanovski <akiyano@amazon.com>
> > >
> > > Update driver version due to bug fix.
> > 
> > Wouldn't you want to do this atomically with the actual fix in one commit?
> > 
> > Thanks,
> > Moritz
> 
> Thanks for the feedback.
> I don't want to add the version to the fix.
> Version 2.0.3 includes all of its content that came before this fix, including features.
> Fixes are cherry-picked to older driver versions automatically using the "Fixes:" directive.
> If I add the version change to the fix, older driver versions that get this fix will become version 2.0.3, which is incorrect feature-wise.

Hi Arthur

I think this points out how useless the version string it, and why
many drivers don't use it.

     Andrew

Patch

diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.h b/drivers/net/ethernet/amazon/ena/ena_netdev.h
index dc8b6173d8d8..63870072cbbd 100644
--- a/drivers/net/ethernet/amazon/ena/ena_netdev.h
+++ b/drivers/net/ethernet/amazon/ena/ena_netdev.h
@@ -45,7 +45,7 @@ 
 
 #define DRV_MODULE_VER_MAJOR	2
 #define DRV_MODULE_VER_MINOR	0
-#define DRV_MODULE_VER_SUBMINOR 2
+#define DRV_MODULE_VER_SUBMINOR 3
 
 #define DRV_MODULE_NAME		"ena"
 #ifndef DRV_MODULE_VERSION