Patchwork [dpdk-dev] compress/isal: add ISA-L lib version display

login
register
mail settings
Submitter Tomasz Cel
Date Feb. 11, 2019, 9:18 a.m.
Message ID <1549876732-9807-1-git-send-email-tomaszx.cel@intel.com>
Download mbox | patch
Permalink /patch/722645/
State New
Headers show

Comments

Tomasz Cel - Feb. 11, 2019, 9:18 a.m.
Display information about ISA-L lib version in UTs.

Signed-off-by: Tomasz Cel <tomaszx.cel@intel.com>
---
 drivers/compress/isal/isal_compress_pmd.c | 8 ++++++++
 1 file changed, 8 insertions(+)
Lee Daly - Feb. 11, 2019, 9:42 a.m.
Hi Tomasz,
	Looks good to me.
> -----Original Message-----
> From: Cel, TomaszX
> Sent: Monday, February 11, 2019 9:19 AM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; Daly, Lee
> <lee.daly@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; Jozwiak, TomaszX
> <tomaszx.jozwiak@intel.com>; Cel, TomaszX <tomaszx.cel@intel.com>
> Subject: [PATCH] compress/isal: add ISA-L lib version display
> 
> Display information about ISA-L lib version in UTs.
> 
> Signed-off-by: Tomasz Cel <tomaszx.cel@intel.com>
> ---
>  drivers/compress/isal/isal_compress_pmd.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/compress/isal/isal_compress_pmd.c
> b/drivers/compress/isal/isal_compress_pmd.c
> index 4748238..8879a42 100644
> --- a/drivers/compress/isal/isal_compress_pmd.c
> +++ b/drivers/compress/isal/isal_compress_pmd.c
<...>

> 2.7.4

Acked-by: Lee Daly <lee.daly@intel.com>
akhil.goyal@nxp.com - March 19, 2019, 2:03 p.m.
On 2/11/2019 3:12 PM, Daly, Lee wrote:
> Hi Tomasz,

> 	Looks good to me.

>> -----Original Message-----

>> From: Cel, TomaszX

>> Sent: Monday, February 11, 2019 9:19 AM

>> To: dev@dpdk.org

>> Cc: stable@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; Daly, Lee

>> <lee.daly@intel.com>; De Lara Guarch, Pablo

>> <pablo.de.lara.guarch@intel.com>; Jozwiak, TomaszX

>> <tomaszx.jozwiak@intel.com>; Cel, TomaszX <tomaszx.cel@intel.com>

>> Subject: [PATCH] compress/isal: add ISA-L lib version display

>>

>> Display information about ISA-L lib version in UTs.

>>

>> Signed-off-by: Tomasz Cel <tomaszx.cel@intel.com>

>> ---

>>   drivers/compress/isal/isal_compress_pmd.c | 8 ++++++++

>>   1 file changed, 8 insertions(+)

>>

>> diff --git a/drivers/compress/isal/isal_compress_pmd.c

>> b/drivers/compress/isal/isal_compress_pmd.c

>> index 4748238..8879a42 100644

>> --- a/drivers/compress/isal/isal_compress_pmd.c

>> +++ b/drivers/compress/isal/isal_compress_pmd.c

> <...>

>

>> 2.7.4

> Acked-by: Lee Daly <lee.daly@intel.com>

>

Applied to dpdk-next-crypto

Thanks.

Patch

diff --git a/drivers/compress/isal/isal_compress_pmd.c b/drivers/compress/isal/isal_compress_pmd.c
index 4748238..8879a42 100644
--- a/drivers/compress/isal/isal_compress_pmd.c
+++ b/drivers/compress/isal/isal_compress_pmd.c
@@ -19,6 +19,12 @@ 
 #define CHKSUM_SZ_CRC 8
 #define CHKSUM_SZ_ADLER 4
 
+#define STRINGIFY(s) #s
+#define ISAL_TOSTRING(maj, min, patch) \
+	STRINGIFY(maj)"."STRINGIFY(min)"."STRINGIFY(patch)
+#define ISAL_VERSION_STRING \
+	ISAL_TOSTRING(ISAL_MAJOR_VERSION, ISAL_MINOR_VERSION, ISAL_PATCH_VERSION)
+
 int isal_logtype_driver;
 
 /* Verify and set private xform parameters */
@@ -684,6 +690,8 @@  compdev_isal_create(const char *name, struct rte_vdev_device *vdev,
 	dev->dequeue_burst = isal_comp_pmd_dequeue_burst;
 	dev->enqueue_burst = isal_comp_pmd_enqueue_burst;
 
+	ISAL_PMD_LOG(INFO, "\nISA-L library version used: "ISAL_VERSION_STRING);
+
 	return 0;
 }