Patchwork [2/2] ACPI x86: Make PWM2 device always present at Lenovo Yoga Book

login
register
mail settings
Submitter Yauhen Kharuzhy
Date Feb. 9, 2019, 10:06 a.m.
Message ID <20190209100612.27196-1-jekhor@gmail.com>
Download mbox | patch
Permalink /patch/722205/
State New
Headers show

Comments

Yauhen Kharuzhy - Feb. 9, 2019, 10:06 a.m.
Lenovo Yoga Book uses PWM2 for controlling keyboard backlight but this
device is hidden in the DSDT in Windows version of notebook (if OSID == 1).

Make this device always present for this notebook.

Signed-off-by: Yauhen Kharuzhy <jekhor@gmail.com>
---
 drivers/acpi/x86/utils.c | 5 +++++
 1 file changed, 5 insertions(+)
Hans de Goede - Feb. 14, 2019, 5:05 p.m.
Hi,

On 09-02-19 11:06, Yauhen Kharuzhy wrote:
> Lenovo Yoga Book uses PWM2 for controlling keyboard backlight but this
> device is hidden in the DSDT in Windows version of notebook (if OSID == 1).
> 
> Make this device always present for this notebook.
> 
> Signed-off-by: Yauhen Kharuzhy <jekhor@gmail.com>

Patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans



> ---
>   drivers/acpi/x86/utils.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/acpi/x86/utils.c b/drivers/acpi/x86/utils.c
> index 9a8e286dd86f..c6df14802741 100644
> --- a/drivers/acpi/x86/utils.c
> +++ b/drivers/acpi/x86/utils.c
> @@ -56,6 +56,11 @@ static const struct always_present_id always_present_ids[] = {
>   	 */
>   	ENTRY("80860F09", "1", ICPU(INTEL_FAM6_ATOM_SILVERMONT), {}),
>   	ENTRY("80862288", "1", ICPU(INTEL_FAM6_ATOM_AIRMONT), {}),
> +
> +	/* Lenovo Yoga Book uses PWM2 for keyboard backlight control */
> +	ENTRY("80862289", "2", ICPU(INTEL_FAM6_ATOM_AIRMONT), {
> +			DMI_MATCH(DMI_PRODUCT_NAME, "Lenovo YB1-X9"),
> +		}),
>   	/*
>   	 * The INT0002 device is necessary to clear wakeup interrupt sources
>   	 * on Cherry Trail devices, without it we get nobody cared IRQ msgs.
>
Rafael J. Wysocki - Feb. 19, 2019, 9:59 a.m.
On Thursday, February 14, 2019 6:05:58 PM CET Hans de Goede wrote:
> Hi,
> 
> On 09-02-19 11:06, Yauhen Kharuzhy wrote:
> > Lenovo Yoga Book uses PWM2 for controlling keyboard backlight but this
> > device is hidden in the DSDT in Windows version of notebook (if OSID == 1).
> > 
> > Make this device always present for this notebook.
> > 
> > Signed-off-by: Yauhen Kharuzhy <jekhor@gmail.com>
> 
> Patch looks good to me:
> 
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> 
> Regards,
> 
> Hans
> 
> 
> 
> > ---
> >   drivers/acpi/x86/utils.c | 5 +++++
> >   1 file changed, 5 insertions(+)
> > 
> > diff --git a/drivers/acpi/x86/utils.c b/drivers/acpi/x86/utils.c
> > index 9a8e286dd86f..c6df14802741 100644
> > --- a/drivers/acpi/x86/utils.c
> > +++ b/drivers/acpi/x86/utils.c
> > @@ -56,6 +56,11 @@ static const struct always_present_id always_present_ids[] = {
> >   	 */
> >   	ENTRY("80860F09", "1", ICPU(INTEL_FAM6_ATOM_SILVERMONT), {}),
> >   	ENTRY("80862288", "1", ICPU(INTEL_FAM6_ATOM_AIRMONT), {}),
> > +
> > +	/* Lenovo Yoga Book uses PWM2 for keyboard backlight control */
> > +	ENTRY("80862289", "2", ICPU(INTEL_FAM6_ATOM_AIRMONT), {
> > +			DMI_MATCH(DMI_PRODUCT_NAME, "Lenovo YB1-X9"),
> > +		}),
> >   	/*
> >   	 * The INT0002 device is necessary to clear wakeup interrupt sources
> >   	 * on Cherry Trail devices, without it we get nobody cared IRQ msgs.
> > 
> 

Patch applied, thanks!

Patch

diff --git a/drivers/acpi/x86/utils.c b/drivers/acpi/x86/utils.c
index 9a8e286dd86f..c6df14802741 100644
--- a/drivers/acpi/x86/utils.c
+++ b/drivers/acpi/x86/utils.c
@@ -56,6 +56,11 @@  static const struct always_present_id always_present_ids[] = {
 	 */
 	ENTRY("80860F09", "1", ICPU(INTEL_FAM6_ATOM_SILVERMONT), {}),
 	ENTRY("80862288", "1", ICPU(INTEL_FAM6_ATOM_AIRMONT), {}),
+
+	/* Lenovo Yoga Book uses PWM2 for keyboard backlight control */
+	ENTRY("80862289", "2", ICPU(INTEL_FAM6_ATOM_AIRMONT), {
+			DMI_MATCH(DMI_PRODUCT_NAME, "Lenovo YB1-X9"),
+		}),
 	/*
 	 * The INT0002 device is necessary to clear wakeup interrupt sources
 	 * on Cherry Trail devices, without it we get nobody cared IRQ msgs.