Patchwork USB: serial: pl2303: add Delock Infrared device id

login
register
mail settings
Submitter ebrahim@gnu.org
Date Feb. 9, 2019, 8:48 a.m.
Message ID <20190209084840.2319-2-ebrahim@gnu.org>
Download mbox | patch
Permalink /patch/722201/
State New
Headers show

Comments

ebrahim@gnu.org - Feb. 9, 2019, 8:48 a.m.
From: Ebrahim Byagowi <ebrahim@gnu.org>

This makes Delock Infrared adapter to work as a USB to Serial device.
---
 drivers/usb/serial/pl2303.c | 1 +
 drivers/usb/serial/pl2303.h | 3 +++
 2 files changed, 4 insertions(+)
Greg Kroah-Hartman - Feb. 9, 2019, 9:08 a.m.
On Sat, Feb 09, 2019 at 12:18:40PM +0330, ebrahim@gnu.org wrote:
> From: Ebrahim Byagowi <ebrahim@gnu.org>
> 
> This makes Delock Infrared adapter to work as a USB to Serial device.
> ---
>  drivers/usb/serial/pl2303.c | 1 +
>  drivers/usb/serial/pl2303.h | 3 +++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
> index 98e7a5df0..d5ec72575 100644
> --- a/drivers/usb/serial/pl2303.c
> +++ b/drivers/usb/serial/pl2303.c
> @@ -105,6 +105,7 @@ static const struct usb_device_id id_table[] = {
>  	{ USB_DEVICE(SANWA_VENDOR_ID, SANWA_PRODUCT_ID) },
>  	{ USB_DEVICE(ADLINK_VENDOR_ID, ADLINK_ND6530_PRODUCT_ID) },
>  	{ USB_DEVICE(SMART_VENDOR_ID, SMART_PRODUCT_ID) },
> +	{ USB_DEVICE(DELOCK_VENDOR_ID, DELOCK_PRODUCT_ID) },
>  	{ }					/* Terminating entry */
>  };
>  
> diff --git a/drivers/usb/serial/pl2303.h b/drivers/usb/serial/pl2303.h
> index 4e2554d55..01936de13 100644
> --- a/drivers/usb/serial/pl2303.h
> +++ b/drivers/usb/serial/pl2303.h
> @@ -153,3 +153,6 @@
>  #define SMART_VENDOR_ID	0x0b8c
>  #define SMART_PRODUCT_ID	0x2303
>  
> +/* Delock Infrared Adapter */
> +#define DELOCK_VENDOR_ID	0x1685
> +#define DELOCK_PRODUCT_ID	0x2000
> -- 
> 2.20.1
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch does not have a Signed-off-by: line.  Please read the
  kernel file, Documentation/SubmittingPatches and resend it after
  adding that line.  Note, the line needs to be in the body of the
  email, before the patch, not at the bottom of the patch or in the
  email signature.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot
Johan Hovold - Feb. 9, 2019, 9:46 a.m.
On Sat, Feb 09, 2019 at 12:18:40PM +0330, ebrahim@gnu.org wrote:
> From: Ebrahim Byagowi <ebrahim@gnu.org>
> 
> This makes Delock Infrared adapter to work as a USB to Serial device.
> ---
>  drivers/usb/serial/pl2303.c | 1 +
>  drivers/usb/serial/pl2303.h | 3 +++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
> index 98e7a5df0..d5ec72575 100644
> --- a/drivers/usb/serial/pl2303.c
> +++ b/drivers/usb/serial/pl2303.c
> @@ -105,6 +105,7 @@ static const struct usb_device_id id_table[] = {
>  	{ USB_DEVICE(SANWA_VENDOR_ID, SANWA_PRODUCT_ID) },
>  	{ USB_DEVICE(ADLINK_VENDOR_ID, ADLINK_ND6530_PRODUCT_ID) },
>  	{ USB_DEVICE(SMART_VENDOR_ID, SMART_PRODUCT_ID) },
> +	{ USB_DEVICE(DELOCK_VENDOR_ID, DELOCK_PRODUCT_ID) },
>  	{ }					/* Terminating entry */
>  };
>  
> diff --git a/drivers/usb/serial/pl2303.h b/drivers/usb/serial/pl2303.h
> index 4e2554d55..01936de13 100644
> --- a/drivers/usb/serial/pl2303.h
> +++ b/drivers/usb/serial/pl2303.h
> @@ -153,3 +153,6 @@
>  #define SMART_VENDOR_ID	0x0b8c
>  #define SMART_PRODUCT_ID	0x2303
>  
> +/* Delock Infrared Adapter */
> +#define DELOCK_VENDOR_ID	0x1685
> +#define DELOCK_PRODUCT_ID	0x2000

Please post the output of lsusb -v for this device, and perhaps also a
log from when connecting the device with driver debugging enabled.

How did you determine that this a pl2303 device?

Johan

Patch

diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 98e7a5df0..d5ec72575 100644
--- a/drivers/usb/serial/pl2303.c
+++ b/drivers/usb/serial/pl2303.c
@@ -105,6 +105,7 @@  static const struct usb_device_id id_table[] = {
 	{ USB_DEVICE(SANWA_VENDOR_ID, SANWA_PRODUCT_ID) },
 	{ USB_DEVICE(ADLINK_VENDOR_ID, ADLINK_ND6530_PRODUCT_ID) },
 	{ USB_DEVICE(SMART_VENDOR_ID, SMART_PRODUCT_ID) },
+	{ USB_DEVICE(DELOCK_VENDOR_ID, DELOCK_PRODUCT_ID) },
 	{ }					/* Terminating entry */
 };
 
diff --git a/drivers/usb/serial/pl2303.h b/drivers/usb/serial/pl2303.h
index 4e2554d55..01936de13 100644
--- a/drivers/usb/serial/pl2303.h
+++ b/drivers/usb/serial/pl2303.h
@@ -153,3 +153,6 @@ 
 #define SMART_VENDOR_ID	0x0b8c
 #define SMART_PRODUCT_ID	0x2303
 
+/* Delock Infrared Adapter */
+#define DELOCK_VENDOR_ID	0x1685
+#define DELOCK_PRODUCT_ID	0x2000