Patchwork xhci: Drop superfluous initialization in xhci_queue_ctrl_tx()

login
register
mail settings
Submitter Andrey Smirnov
Date Feb. 7, 2019, 12:03 a.m.
Message ID <20190207000331.7547-1-andrew.smirnov@gmail.com>
Download mbox | patch
Permalink /patch/719953/
State New
Headers show

Comments

Andrey Smirnov - Feb. 7, 2019, 12:03 a.m.
Simplify filed's initialization by directly assigning its final value
instead of initializing the variable to sero and then bitwise or-ing
it.

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Mathias Nyman <mathias.nyman@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
 drivers/usb/host/xhci-ring.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Sergei Shtylyov - Feb. 7, 2019, 4:43 p.m.
Hello!

On 07.02.2019 3:03, Andrey Smirnov wrote:

> Simplify filed's initialization by directly assigning its final value

    field's.

> instead of initializing the variable to sero and then bitwise or-ing
> it.
> 
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> Cc: Mathias Nyman <mathias.nyman@intel.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-usb@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
[...]

MBR, Sergei
Andrey Smirnov - Feb. 7, 2019, 9:07 p.m.
On Thu, Feb 7, 2019 at 8:44 AM Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
>
> Hello!
>
> On 07.02.2019 3:03, Andrey Smirnov wrote:
>
> > Simplify filed's initialization by directly assigning its final value
>
>     field's.
>

Oops, missed that. Will fix in v2.

Thanks,
Andrey Smirnov

Patch

diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
index 40fa25c4d041..91e592bfb80d 100644
--- a/drivers/usb/host/xhci-ring.c
+++ b/drivers/usb/host/xhci-ring.c
@@ -3379,8 +3379,7 @@  int xhci_queue_ctrl_tx(struct xhci_hcd *xhci, gfp_t mem_flags,
 	/* Queue setup TRB - see section 6.4.1.2.1 */
 	/* FIXME better way to translate setup_packet into two u32 fields? */
 	setup = (struct usb_ctrlrequest *) urb->setup_packet;
-	field = 0;
-	field |= TRB_IDT | TRB_TYPE(TRB_SETUP);
+	field = TRB_IDT | TRB_TYPE(TRB_SETUP);
 	if (start_cycle == 0)
 		field |= 0x1;