Patchwork [3/3] udc: net2280: Fix typo

login
register
mail settings
Submitter Guido Kiener
Date Feb. 4, 2019, 6:04 p.m.
Message ID <20190204180422.5095-3-guido@kiener-muenchen.de>
Download mbox | patch
Permalink /patch/717587/
State New
Headers show

Comments

Guido Kiener - Feb. 4, 2019, 6:04 p.m.
From: Guido Kiener <guido.kiener@rohde-schwarz.com>

Fix spelling of automatically.

Signed-off-by: Guido Kiener <guido.kiener@rohde-schwarz.com>
---
 drivers/usb/gadget/udc/net2280.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Alan Stern - Feb. 4, 2019, 6:45 p.m.
On Mon, 4 Feb 2019, Guido Kiener wrote:

> From: Guido Kiener <guido.kiener@rohde-schwarz.com>
> 
> Fix spelling of automatically.
> 
> Signed-off-by: Guido Kiener <guido.kiener@rohde-schwarz.com>
> ---
>  drivers/usb/gadget/udc/net2280.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/udc/net2280.c b/drivers/usb/gadget/udc/net2280.c
> index 1cb58fd5d1c6..430d582d8b6e 100644
> --- a/drivers/usb/gadget/udc/net2280.c
> +++ b/drivers/usb/gadget/udc/net2280.c
> @@ -912,7 +912,7 @@ static void start_dma(struct net2280_ep *ep, struct net2280_request *req)
>  	tmp = dmactl_default;
>  
>  	/* force packet boundaries between dma requests, but prevent the
> -	 * controller from automagically writing a last "short" packet
> +	 * controller from automatically writing a last "short" packet

This is not a misspelling.  It is deliberate:

	http://www.hacker-dictionary.com/terms/automagically

Alan Stern

>  	 * (zero length) unless the driver explicitly said to do that.
>  	 */
>  	if (ep->is_in) {
>
Guido Kiener - Feb. 5, 2019, 3:22 p.m.
Zitat von Alan Stern <stern@rowland.harvard.edu>:

> On Mon, 4 Feb 2019, Guido Kiener wrote:
>
>> From: Guido Kiener <guido.kiener@rohde-schwarz.com>
>>
>> Fix spelling of automatically.
>>
>> Signed-off-by: Guido Kiener <guido.kiener@rohde-schwarz.com>
>> ---
>> drivers/usb/gadget/udc/net2280.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/gadget/udc/net2280.c  
>> b/drivers/usb/gadget/udc/net2280.c
>> index 1cb58fd5d1c6..430d582d8b6e 100644
>> --- a/drivers/usb/gadget/udc/net2280.c
>> +++ b/drivers/usb/gadget/udc/net2280.c
>> @@ -912,7 +912,7 @@ static void start_dma(struct net2280_ep *ep,  
>> struct net2280_request *req)
>> 	tmp = dmactl_default;
>>
>> 	/* force packet boundaries between dma requests, but prevent the
>> -	 * controller from automagically writing a last "short" packet
>> +	 * controller from automatically writing a last "short" packet
>
> This is not a misspelling.  It is deliberate:
>
> 	http://www.hacker-dictionary.com/terms/automagically
>
Thank you and I'm sorry for my stupid idea to revise the spelling of a
native speaker. I will not trust my editor's dictionary anymore :-)

Of course I withdraw this patch.

Guido

Patch

diff --git a/drivers/usb/gadget/udc/net2280.c b/drivers/usb/gadget/udc/net2280.c
index 1cb58fd5d1c6..430d582d8b6e 100644
--- a/drivers/usb/gadget/udc/net2280.c
+++ b/drivers/usb/gadget/udc/net2280.c
@@ -912,7 +912,7 @@  static void start_dma(struct net2280_ep *ep, struct net2280_request *req)
 	tmp = dmactl_default;
 
 	/* force packet boundaries between dma requests, but prevent the
-	 * controller from automagically writing a last "short" packet
+	 * controller from automatically writing a last "short" packet
 	 * (zero length) unless the driver explicitly said to do that.
 	 */
 	if (ep->is_in) {