Patchwork [kvmtool,4/6] Makefile: Remove echoing of kvmtools version file

login
register
mail settings
Submitter Andre Przywara
Date Jan. 25, 2019, 6:07 p.m.
Message ID <20190125180801.209910-5-andre.przywara@arm.com>
Download mbox | patch
Permalink /patch/710051/
State New
Headers show

Comments

Andre Przywara - Jan. 25, 2019, 6:07 p.m.
On every build we report the kvmtool "version" number, which isn't
meaningful at all anymore.

Remove the line from the KVMTOOLS-VERSION-GEN script to drop a
pointless message.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
 util/KVMTOOLS-VERSION-GEN | 1 -
 1 file changed, 1 deletion(-)
Will Deacon - Jan. 30, 2019, 6:20 p.m.
On Fri, Jan 25, 2019 at 06:07:59PM +0000, Andre Przywara wrote:
> On every build we report the kvmtool "version" number, which isn't
> meaningful at all anymore.
> 
> Remove the line from the KVMTOOLS-VERSION-GEN script to drop a
> pointless message.
> 
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> ---
>  util/KVMTOOLS-VERSION-GEN | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/util/KVMTOOLS-VERSION-GEN b/util/KVMTOOLS-VERSION-GEN
> index f0dcfdea..91ee2c2f 100755
> --- a/util/KVMTOOLS-VERSION-GEN
> +++ b/util/KVMTOOLS-VERSION-GEN
> @@ -35,6 +35,5 @@ else
>  	VC=unset
>  fi
>  test "$VN" = "$VC" || {
> -	echo >&2 "KVMTOOLS_VERSION = $VN"
>  	echo "KVMTOOLS_VERSION = $VN" >$GVF

It's probably fine, but can you check this doesn't break the debian
packaging please?

Will
Andre Przywara - Jan. 31, 2019, 6:36 p.m.
On Wed, 30 Jan 2019 18:20:36 +0000
Will Deacon <will.deacon@arm.com> wrote:

> On Fri, Jan 25, 2019 at 06:07:59PM +0000, Andre Przywara wrote:
> > On every build we report the kvmtool "version" number, which isn't
> > meaningful at all anymore.
> > 
> > Remove the line from the KVMTOOLS-VERSION-GEN script to drop a
> > pointless message.
> > 
> > Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> > ---
> >  util/KVMTOOLS-VERSION-GEN | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/util/KVMTOOLS-VERSION-GEN b/util/KVMTOOLS-VERSION-GEN
> > index f0dcfdea..91ee2c2f 100755
> > --- a/util/KVMTOOLS-VERSION-GEN
> > +++ b/util/KVMTOOLS-VERSION-GEN
> > @@ -35,6 +35,5 @@ else
> >  	VC=unset
> >  fi
> >  test "$VN" = "$VC" || {
> > -	echo >&2 "KVMTOOLS_VERSION = $VN"
> >  	echo "KVMTOOLS_VERSION = $VN" >$GVF  
> 
> It's probably fine, but can you check this doesn't break the debian
> packaging please?

Debian uses some date-based versioning (0.20170904-1) for kvmtool. I
built it with debuild and this patch in the patches directory, that
seemed to be fine (from my rather clueless Debian packaging point of
view, at least).

Cheers,
Andre.

Patch

diff --git a/util/KVMTOOLS-VERSION-GEN b/util/KVMTOOLS-VERSION-GEN
index f0dcfdea..91ee2c2f 100755
--- a/util/KVMTOOLS-VERSION-GEN
+++ b/util/KVMTOOLS-VERSION-GEN
@@ -35,6 +35,5 @@  else
 	VC=unset
 fi
 test "$VN" = "$VC" || {
-	echo >&2 "KVMTOOLS_VERSION = $VN"
 	echo "KVMTOOLS_VERSION = $VN" >$GVF
 }