Patchwork ACPI / DPTF: remove header search path to the parent directory

login
register
mail settings
Submitter Masahiro Yamada
Date Jan. 24, 2019, 12:16 p.m.
Message ID <1548332163-17869-1-git-send-email-yamada.masahiro@socionext.com>
Download mbox | patch
Permalink /patch/708387/
State New
Headers show

Comments

Masahiro Yamada - Jan. 24, 2019, 12:16 p.m.
It is too much to add extra header search path for all files in
drivers/acpi/dptf/.

Fix up one C file, and remove the header search path.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

My main motivation is to get rid of crappy header search path manipulation
from Kbuild core.

Before that, I want to clean up as many useless paths as possible.

The full work of this is available at:
git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git build-test


 drivers/acpi/dptf/Makefile          | 2 --
 drivers/acpi/dptf/int340x_thermal.c | 2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)
Rafael J. Wysocki - Jan. 30, 2019, 11:56 p.m.
On Thursday, January 24, 2019 1:16:03 PM CET Masahiro Yamada wrote:
> It is too much to add extra header search path for all files in
> drivers/acpi/dptf/.
> 
> Fix up one C file, and remove the header search path.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
> 
> My main motivation is to get rid of crappy header search path manipulation
> from Kbuild core.
> 
> Before that, I want to clean up as many useless paths as possible.
> 
> The full work of this is available at:
> git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git build-test
> 
> 
>  drivers/acpi/dptf/Makefile          | 2 --
>  drivers/acpi/dptf/int340x_thermal.c | 2 +-
>  2 files changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/acpi/dptf/Makefile b/drivers/acpi/dptf/Makefile
> index 06ea880..e6032e4 100644
> --- a/drivers/acpi/dptf/Makefile
> +++ b/drivers/acpi/dptf/Makefile
> @@ -1,4 +1,2 @@
>  obj-$(CONFIG_ACPI)             += int340x_thermal.o
>  obj-$(CONFIG_DPTF_POWER)	+= dptf_power.o
> -
> -ccflags-y += -Idrivers/acpi
> diff --git a/drivers/acpi/dptf/int340x_thermal.c b/drivers/acpi/dptf/int340x_thermal.c
> index 8636409..0aa7c2e 100644
> --- a/drivers/acpi/dptf/int340x_thermal.c
> +++ b/drivers/acpi/dptf/int340x_thermal.c
> @@ -12,7 +12,7 @@
>  #include <linux/acpi.h>
>  #include <linux/module.h>
>  
> -#include "internal.h"
> +#include "../internal.h"
>  
>  #define INT3401_DEVICE 0X01
>  static const struct acpi_device_id int340x_thermal_device_ids[] = {
> 

Applied, thanks!

Patch

diff --git a/drivers/acpi/dptf/Makefile b/drivers/acpi/dptf/Makefile
index 06ea880..e6032e4 100644
--- a/drivers/acpi/dptf/Makefile
+++ b/drivers/acpi/dptf/Makefile
@@ -1,4 +1,2 @@ 
 obj-$(CONFIG_ACPI)             += int340x_thermal.o
 obj-$(CONFIG_DPTF_POWER)	+= dptf_power.o
-
-ccflags-y += -Idrivers/acpi
diff --git a/drivers/acpi/dptf/int340x_thermal.c b/drivers/acpi/dptf/int340x_thermal.c
index 8636409..0aa7c2e 100644
--- a/drivers/acpi/dptf/int340x_thermal.c
+++ b/drivers/acpi/dptf/int340x_thermal.c
@@ -12,7 +12,7 @@ 
 #include <linux/acpi.h>
 #include <linux/module.h>
 
-#include "internal.h"
+#include "../internal.h"
 
 #define INT3401_DEVICE 0X01
 static const struct acpi_device_id int340x_thermal_device_ids[] = {