Patchwork [1/4] EDAC, altera: Fix S10 persistent register offset

login
register
mail settings
Submitter thor.thayer@linux.intel.com
Date Jan. 16, 2019, 11:11 p.m.
Message ID <1547680314-31045-2-git-send-email-thor.thayer@linux.intel.com>
Download mbox | patch
Permalink /patch/701885/
State New
Headers show

Comments

thor.thayer@linux.intel.com - Jan. 16, 2019, 11:11 p.m.
From: Thor Thayer <thor.thayer@linux.intel.com>

Correct the persistent register offset where address
and status are stored.

Fixes: 08f08bfb7b4c ("EDAC, altera: Merge Stratix10 into the Arria10 SDRAM
		      probe routine")
Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com>
---
 drivers/edac/altera_edac.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Dinh Nguyen - Jan. 17, 2019, 2:52 p.m.
On 1/16/19 5:11 PM, thor.thayer@linux.intel.com wrote:
> From: Thor Thayer <thor.thayer@linux.intel.com>
> 
> Correct the persistent register offset where address
> and status are stored.
> 
> Fixes: 08f08bfb7b4c ("EDAC, altera: Merge Stratix10 into the Arria10 SDRAM
> 		      probe routine")

The "Fixes" line should be all on one line. I recently got dinged for this.

From Documentation/process/submitting-patches.rst"

"If your patch fixes a bug in a specific commit, e.g. you found an issue
using
``git bisect``, please use the 'Fixes:' tag with the first 12 characters of
the SHA-1 ID, and the one line summary.  For example::

Fixes: e21d2170f366 ("video: remove unnecessary platform_set_drvdata()")"

Dinh
thor.thayer@linux.intel.com - Jan. 17, 2019, 3:36 p.m.
On 1/17/19 8:52 AM, Dinh Nguyen wrote:
> 
> 
> On 1/16/19 5:11 PM, thor.thayer@linux.intel.com wrote:
>> From: Thor Thayer <thor.thayer@linux.intel.com>
>>
>> Correct the persistent register offset where address
>> and status are stored.
>>
>> Fixes: 08f08bfb7b4c ("EDAC, altera: Merge Stratix10 into the Arria10 SDRAM
>> 		      probe routine")
> 
> The "Fixes" line should be all on one line. I recently got dinged for this.
> 
>>From Documentation/process/submitting-patches.rst"
> 
> "If your patch fixes a bug in a specific commit, e.g. you found an issue
> using
> ``git bisect``, please use the 'Fixes:' tag with the first 12 characters of
> the SHA-1 ID, and the one line summary.  For example::
> 
> Fixes: e21d2170f366 ("video: remove unnecessary platform_set_drvdata()")"
> 
> Dinh
> I'll fix that and send out another patchset. Thanks Dinh.

Patch

diff --git a/drivers/edac/altera_edac.h b/drivers/edac/altera_edac.h
index 4213cb0bb2a7..f8664bac9fa8 100644
--- a/drivers/edac/altera_edac.h
+++ b/drivers/edac/altera_edac.h
@@ -295,8 +295,8 @@  struct altr_sdram_mc_data {
 #define S10_SYSMGR_ECC_INTSTAT_DERR_OFST  0xA0
 
 /* Sticky registers for Uncorrected Errors */
-#define S10_SYSMGR_UE_VAL_OFST            0x120
-#define S10_SYSMGR_UE_ADDR_OFST           0x124
+#define S10_SYSMGR_UE_VAL_OFST            0x220
+#define S10_SYSMGR_UE_ADDR_OFST           0x224
 
 #define S10_DDR0_IRQ_MASK                 BIT(16)