Patchwork [dpdk-dev,v3,3/4] build: reorder libraries and build eal before cmdline

login
register
mail settings
Submitter Luca Boccassi
Date Jan. 11, 2019, 4:26 p.m.
Message ID <20190111162608.13162-3-bluca@debian.org>
Download mbox | patch
Permalink /patch/697875/
State New
Headers show

Comments

Luca Boccassi - Jan. 11, 2019, 4:26 p.m.
Most libraries and PMDs depend on eal, and eal depends only on kvargs,
so reorder the list in Meson to reflect this and take advantage of this
dependency chain.

Signed-off-by: Luca Boccassi <bluca@debian.org>
---
v3: added this patch to let the next just update librte_eal instead of
    also having to update rte_cmdline

 lib/meson.build | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Bruce Richardson - Jan. 11, 2019, 5:22 p.m.
On Fri, Jan 11, 2019 at 04:26:07PM +0000, Luca Boccassi wrote:
> Most libraries and PMDs depend on eal, and eal depends only on kvargs,
> so reorder the list in Meson to reflect this and take advantage of this
> dependency chain.
> 
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> ---
> v3: added this patch to let the next just update librte_eal instead of
>     also having to update rte_cmdline
> 
>  lib/meson.build | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/meson.build b/lib/meson.build
> index a2dd52e17..bf8417c6d 100644
> --- a/lib/meson.build
> +++ b/lib/meson.build
> @@ -9,9 +9,10 @@
>  # given as a dep, no need to mention ring. This is especially true for the
>  # core libs which are widely reused, so their deps are kept to a minimum.
>  libraries = [ 'compat', # just a header, used for versioning
> -	'cmdline', # ethdev depends on cmdline for parsing functions
>  	'kvargs', # eal depends on kvargs
> -	'eal', 'ring', 'mempool', 'mbuf', 'net', 'meter', 'ethdev', 'pci', # core
> +	'eal', # everything depends on eal
> +	'cmdline', # ethdev depends on cmdline for parsing functions
> +	'ring', 'mempool', 'mbuf', 'net', 'meter', 'ethdev', 'pci', # core
>  	'metrics', # bitrate/latency stats depends on this
>  	'hash',    # efd depends on this
>  	'timer',   # eventdev depends on this

This is a saner build order, so

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Patch

diff --git a/lib/meson.build b/lib/meson.build
index a2dd52e17..bf8417c6d 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -9,9 +9,10 @@ 
 # given as a dep, no need to mention ring. This is especially true for the
 # core libs which are widely reused, so their deps are kept to a minimum.
 libraries = [ 'compat', # just a header, used for versioning
-	'cmdline', # ethdev depends on cmdline for parsing functions
 	'kvargs', # eal depends on kvargs
-	'eal', 'ring', 'mempool', 'mbuf', 'net', 'meter', 'ethdev', 'pci', # core
+	'eal', # everything depends on eal
+	'cmdline', # ethdev depends on cmdline for parsing functions
+	'ring', 'mempool', 'mbuf', 'net', 'meter', 'ethdev', 'pci', # core
 	'metrics', # bitrate/latency stats depends on this
 	'hash',    # efd depends on this
 	'timer',   # eventdev depends on this