Patchwork [v2,3/4] usb: musb: Kconfig: Drop dependency on MACH_JZ4740 for jz4740

login
register
mail settings
Submitter Paul Cercueil
Date Jan. 10, 2019, 1:36 p.m.
Message ID <20190110133700.4471-3-paul@crapouillou.net>
Download mbox | patch
Permalink /patch/696615/
State New
Headers show

Comments

Paul Cercueil - Jan. 10, 2019, 1:36 p.m.
Depending on MACH_INGENIC prevent us from creating a generic kernel that
works on more than one MIPS board. Instead, we just depend on MIPS being
set.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---

v2: Remove info about adding COMPILE_TEST in commit message, as it was
    there before

 drivers/usb/musb/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Bin Liu - Jan. 15, 2019, 4:26 p.m.
Hi Paul,

On Thu, Jan 10, 2019 at 10:36:59AM -0300, Paul Cercueil wrote:
> Depending on MACH_INGENIC prevent us from creating a generic kernel that

Again, did you mean MACH_JZ4740 instead?

> works on more than one MIPS board. Instead, we just depend on MIPS being
> set.
> 
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> 
> v2: Remove info about adding COMPILE_TEST in commit message, as it was
>     there before
> 
>  drivers/usb/musb/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
> index ad08895e78f9..6f5b0ed6a507 100644
> --- a/drivers/usb/musb/Kconfig
> +++ b/drivers/usb/musb/Kconfig
> @@ -111,7 +111,7 @@ config USB_MUSB_UX500
>  config USB_MUSB_JZ4740
>  	tristate "JZ4740"
>  	depends on NOP_USB_XCEIV
> -	depends on MACH_JZ4740 || COMPILE_TEST
> +	depends on MIPS || COMPILE_TEST
>  	depends on USB_MUSB_GADGET
>  	depends on USB_OTG_BLACKLIST_HUB
  
Regards,
-Bin.
Paul Cercueil - Jan. 17, 2019, 10:31 p.m.
Hi,

On Tue, Jan 15, 2019 at 1:26 PM, Bin Liu <b-liu@ti.com> wrote:
> Hi Paul,
> 
> On Thu, Jan 10, 2019 at 10:36:59AM -0300, Paul Cercueil wrote:
>>  Depending on MACH_INGENIC prevent us from creating a generic kernel 
>> that
> 
> Again, did you mean MACH_JZ4740 instead?

Dammit. I'm sorry. Will send a v3 right now.

>>  works on more than one MIPS board. Instead, we just depend on MIPS 
>> being
>>  set.
>> 
>>  Signed-off-by: Paul Cercueil <paul@crapouillou.net 
>> <mailto:paul@crapouillou.net>>
>>  ---
>> 
>>  v2: Remove info about adding COMPILE_TEST in commit message, as it 
>> was
>>      there before
>> 
>>   drivers/usb/musb/Kconfig | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>>  diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
>>  index ad08895e78f9..6f5b0ed6a507 100644
>>  --- a/drivers/usb/musb/Kconfig
>>  +++ b/drivers/usb/musb/Kconfig
>>  @@ -111,7 +111,7 @@ config USB_MUSB_UX500
>>   config USB_MUSB_JZ4740
>>   	tristate "JZ4740"
>>   	depends on NOP_USB_XCEIV
>>  -	depends on MACH_JZ4740 || COMPILE_TEST
>>  +	depends on MIPS || COMPILE_TEST
>>   	depends on USB_MUSB_GADGET
>>   	depends on USB_OTG_BLACKLIST_HUB
> 
> Regards,
> -Bin.

Patch

diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
index ad08895e78f9..6f5b0ed6a507 100644
--- a/drivers/usb/musb/Kconfig
+++ b/drivers/usb/musb/Kconfig
@@ -111,7 +111,7 @@  config USB_MUSB_UX500
 config USB_MUSB_JZ4740
 	tristate "JZ4740"
 	depends on NOP_USB_XCEIV
-	depends on MACH_JZ4740 || COMPILE_TEST
+	depends on MIPS || COMPILE_TEST
 	depends on USB_MUSB_GADGET
 	depends on USB_OTG_BLACKLIST_HUB