Patchwork drivers/usb/storage/jumpshot.c: Remove duplicate header

login
register
mail settings
Submitter Sabyasachi Gupta
Date Jan. 10, 2019, 7:33 a.m.
Message ID <5c36f533.1c69fb81.253c8.2646@mx.google.com>
Download mbox | patch
Permalink /patch/696397/
State New
Headers show

Comments

Sabyasachi Gupta - Jan. 10, 2019, 7:33 a.m.
Remove unusual_jumpshot.h which is included more than once.

Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
---
 drivers/usb/storage/jumpshot.c | 1 -
 1 file changed, 1 deletion(-)
Oliver Neukum - Jan. 10, 2019, 7:41 a.m.
On Do, 2019-01-10 at 13:03 +0530, Sabyasachi Gupta wrote:
> Remove unusual_jumpshot.h which is included more than once.
> 
> Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
> ---
>  drivers/usb/storage/jumpshot.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/usb/storage/jumpshot.c b/drivers/usb/storage/jumpshot.c
> index 917f170..06e46c6 100644
> --- a/drivers/usb/storage/jumpshot.c
> +++ b/drivers/usb/storage/jumpshot.c
> @@ -84,7 +84,6 @@ MODULE_DEVICE_TABLE(usb, jumpshot_usb_ids);
>  }
>  
>  static struct us_unusual_dev jumpshot_unusual_dev_list[] = {
> -#	include "unusual_jumpshot.h"
>  	{ }		/* Terminating entry */
>  };
>  

NACK.

It is included twice because the same device needs to be specified
and is quirky. You are breaking the driver.

	Regards
		Oliver

Patch

diff --git a/drivers/usb/storage/jumpshot.c b/drivers/usb/storage/jumpshot.c
index 917f170..06e46c6 100644
--- a/drivers/usb/storage/jumpshot.c
+++ b/drivers/usb/storage/jumpshot.c
@@ -84,7 +84,6 @@  MODULE_DEVICE_TABLE(usb, jumpshot_usb_ids);
 }
 
 static struct us_unusual_dev jumpshot_unusual_dev_list[] = {
-#	include "unusual_jumpshot.h"
 	{ }		/* Terminating entry */
 };