Patchwork [2/2] ACPI / video: Extend chassis-type detection with a "Lunch Box" check

login
register
mail settings
Submitter Hans de Goede
Date Jan. 7, 2019, 4:08 p.m.
Message ID <20190107160821.26961-2-hdegoede@redhat.com>
Download mbox | patch
Permalink /patch/693999/
State New
Headers show

Comments

Hans de Goede - Jan. 7, 2019, 4:08 p.m.
commit 53fa1f6e8a59 ("ACPI / video: Only default only_lcd to true on
Win8-ready _desktops_") introduced chassis type detection, limiting the
lcd_only check for the backlight to devices where the chassis-type
indicates their is no builtin LCD panel.

The purpose of the lcd_only check is to avoid advertising a backlight
interface on desktops, since skylake and newer machines seem to always
have a backlight interface even if there is no LCD panel. The limiting
of this check to desktops only was done to avoid breaking backlight
support on some laptops which do not have the lcd flag set.

The Fujitsu ESPRIMO Q910 which is a compact (NUC like) desktop machine
has a chassis type of 0x10 aka "Lunch Box". Without the lcd_only check
we end up falsely advertising backlight/brightness control on this
device. This commit extend the dmi_is_desktop check to return true
for type 0x10 to fix this.

Fixes: 53fa1f6e8a59 ("ACPI / video: Only default only_lcd to true ...")
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/acpi/acpi_video.c | 1 +
 1 file changed, 1 insertion(+)

Patch

diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c
index ba5c2f70babe..4a03e1c9fe5d 100644
--- a/drivers/acpi/acpi_video.c
+++ b/drivers/acpi/acpi_video.c
@@ -2143,6 +2143,7 @@  static bool dmi_is_desktop(void)
 	case 0x05: return true; /* Pizza Box */
 	case 0x06: return true; /* Mini Tower */
 	case 0x07: return true; /* Tower */
+	case 0x10: return true; /* Lunch Box */
 	case 0x11: return true; /* Main Server Chassis */
 	}