Patchwork [V2] roles: Fix for Enabling USB ROLE SWITCH QUIRK on INTEL_SUNRISEPOINT_LP_XHCI

login
register
mail settings
Submitter m.balaji@intel.com
Date Jan. 8, 2019, 10:04 a.m.
Message ID <20190108100420.17476-1-m.balaji@intel.com>
Download mbox | patch
Permalink /patch/693699/
State New
Headers show

Comments

Hans de Goede - Jan. 7, 2019, 10:49 a.m.
Hi,

On 08-01-19 11:04, m.balaji@intel.com wrote:
> From: M, Balaji <m.balaji@intel.com>
> 
> This fix enables USB role feature on intel commercial nuc
> platform which is based on Kabylake chipset.
> 
> Signed-off-by: M, Balaji <m.balaji@intel.com>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> ---
>   Changes from v1: Added Reviewed-by

There is no need to send out a v2 just to add a Reviewed-by,
the subsys-maintainer will pick the Reviewed-by up when merging.

If you need to do a v2 to add some other minor change adding the
Reviewed-by is fine.

Regards,

Hans


>   drivers/usb/host/xhci-pci.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> index a9ec7051f286..c2fe218e051f 100644
> --- a/drivers/usb/host/xhci-pci.c
> +++ b/drivers/usb/host/xhci-pci.c
> @@ -194,6 +194,7 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
>   		xhci->quirks |= XHCI_SSIC_PORT_UNUSED;
>   	if (pdev->vendor == PCI_VENDOR_ID_INTEL &&
>   	    (pdev->device == PCI_DEVICE_ID_INTEL_CHERRYVIEW_XHCI ||
> +	     pdev->device == PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_XHCI ||
>   	     pdev->device == PCI_DEVICE_ID_INTEL_APL_XHCI))
>   		xhci->quirks |= XHCI_INTEL_USB_ROLE_SW;
>   	if (pdev->vendor == PCI_VENDOR_ID_INTEL &&
>
Heikki Krogerus - Jan. 7, 2019, 11:36 a.m.
On Tue, Jan 08, 2019 at 05:04:20AM -0500, m.balaji@intel.com wrote:
> From: M, Balaji <m.balaji@intel.com>
> 
> This fix enables USB role feature on intel commercial nuc
> platform which is based on Kabylake chipset.
> 
> Signed-off-by: M, Balaji <m.balaji@intel.com>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>

OK by me:

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

Do not send an other version where you add just that tag! Mathias, as
the maintainer, will take care of adding the tag to the commit.

> ---
>  Changes from v1: Added Reviewed-by
>  drivers/usb/host/xhci-pci.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> index a9ec7051f286..c2fe218e051f 100644
> --- a/drivers/usb/host/xhci-pci.c
> +++ b/drivers/usb/host/xhci-pci.c
> @@ -194,6 +194,7 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
>  		xhci->quirks |= XHCI_SSIC_PORT_UNUSED;
>  	if (pdev->vendor == PCI_VENDOR_ID_INTEL &&
>  	    (pdev->device == PCI_DEVICE_ID_INTEL_CHERRYVIEW_XHCI ||
> +	     pdev->device == PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_XHCI ||
>  	     pdev->device == PCI_DEVICE_ID_INTEL_APL_XHCI))
>  		xhci->quirks |= XHCI_INTEL_USB_ROLE_SW;
>  	if (pdev->vendor == PCI_VENDOR_ID_INTEL &&
> -- 
> 2.17.1

thanks,
m.balaji@intel.com - Jan. 7, 2019, 2:58 p.m.
> -----Original Message-----

> From: linux-usb-owner@vger.kernel.org [mailto:linux-usb-

> owner@vger.kernel.org] On Behalf Of Hans de Goede

> Sent: Monday, January 7, 2019 4:20 PM

> To: Balaji, M <m.balaji@intel.com>; linux-usb@vger.kernel.org

> Cc: mathias.nyman@linux.intel.com; heikki.krogerus@linux.intel.com

> Subject: Re: [PATCH V2] roles: Fix for Enabling USB ROLE SWITCH QUIRK on

> INTEL_SUNRISEPOINT_LP_XHCI

> 

> Hi,

> 

> On 08-01-19 11:04, m.balaji@intel.com wrote:

> > From: M, Balaji <m.balaji@intel.com>

> >

> > This fix enables USB role feature on intel commercial nuc

> > platform which is based on Kabylake chipset.

> >

> > Signed-off-by: M, Balaji <m.balaji@intel.com>

> > Reviewed-by: Hans de Goede <hdegoede@redhat.com>

> > ---

> >   Changes from v1: Added Reviewed-by

> 

> There is no need to send out a v2 just to add a Reviewed-by,

> the subsys-maintainer will pick the Reviewed-by up when merging.

> 

> If you need to do a v2 to add some other minor change adding the

> Reviewed-by is fine.

> 

> Regards,

> 

> Hans


Hello Hans , 

Sure got it , thanks Will take care next time . 

Regards ,

Balaji 
> 

> 

> >   drivers/usb/host/xhci-pci.c | 1 +

> >   1 file changed, 1 insertion(+)

> >

> > diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c

> > index a9ec7051f286..c2fe218e051f 100644

> > --- a/drivers/usb/host/xhci-pci.c

> > +++ b/drivers/usb/host/xhci-pci.c

> > @@ -194,6 +194,7 @@ static void xhci_pci_quirks(struct device *dev, struct

> xhci_hcd *xhci)

> >   		xhci->quirks |= XHCI_SSIC_PORT_UNUSED;

> >   	if (pdev->vendor == PCI_VENDOR_ID_INTEL &&

> >   	    (pdev->device == PCI_DEVICE_ID_INTEL_CHERRYVIEW_XHCI ||

> > +	     pdev->device == PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_XHCI ||

> >   	     pdev->device == PCI_DEVICE_ID_INTEL_APL_XHCI))

> >   		xhci->quirks |= XHCI_INTEL_USB_ROLE_SW;

> >   	if (pdev->vendor == PCI_VENDOR_ID_INTEL &&

> >
Greg KH - Jan. 7, 2019, 4:15 p.m.
On Tue, Jan 08, 2019 at 05:04:20AM -0500, m.balaji@intel.com wrote:
> From: M, Balaji <m.balaji@intel.com>
> 
> This fix enables USB role feature on intel commercial nuc
> platform which is based on Kabylake chipset.

Your subject prefix is a bit odd "roles" is not a global thing, it
should look something like:
	usb: xhci: fix for enabling...

thanks,

greg k-h
m.balaji@intel.com - Jan. 8, 2019, 10:04 a.m.
From: M, Balaji <m.balaji@intel.com>

This fix enables USB role feature on intel commercial nuc
platform which is based on Kabylake chipset.

Signed-off-by: M, Balaji <m.balaji@intel.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
---
 Changes from v1: Added Reviewed-by
 drivers/usb/host/xhci-pci.c | 1 +
 1 file changed, 1 insertion(+)

Patch

diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index a9ec7051f286..c2fe218e051f 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -194,6 +194,7 @@  static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
 		xhci->quirks |= XHCI_SSIC_PORT_UNUSED;
 	if (pdev->vendor == PCI_VENDOR_ID_INTEL &&
 	    (pdev->device == PCI_DEVICE_ID_INTEL_CHERRYVIEW_XHCI ||
+	     pdev->device == PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_XHCI ||
 	     pdev->device == PCI_DEVICE_ID_INTEL_APL_XHCI))
 		xhci->quirks |= XHCI_INTEL_USB_ROLE_SW;
 	if (pdev->vendor == PCI_VENDOR_ID_INTEL &&