Patchwork [v4,03/11] vga-switcheroo: make PCI dependency explicit

login
register
mail settings
Submitter Sinan Kaya
Date Dec. 30, 2018, 7:56 p.m.
Message ID <20181230195612.6657-4-okaya@kernel.org>
Download mbox | patch
Permalink /patch/690995/
State New
Headers show

Comments

Sinan Kaya - Dec. 30, 2018, 7:56 p.m.
This driver depends on the PCI infrastructure but the dependency has not
been explicitly called out.

Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
Reviewed-by: Lukas Wunner <lukas@wunner.de>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/vga/Kconfig | 1 +
 1 file changed, 1 insertion(+)
Daniel Vetter - Jan. 7, 2019, 10:34 a.m.
On Sun, Dec 30, 2018 at 07:56:04PM +0000, Sinan Kaya wrote:
> This driver depends on the PCI infrastructure but the dependency has not
> been explicitly called out.
> 
> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
> Reviewed-by: Lukas Wunner <lukas@wunner.de>
> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>

I'm assuming this goes in through the acpi tree, correct?
-Daniel

> ---
>  drivers/gpu/vga/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/vga/Kconfig b/drivers/gpu/vga/Kconfig
> index b677e5d524e6..d5f1d8e1c6f8 100644
> --- a/drivers/gpu/vga/Kconfig
> +++ b/drivers/gpu/vga/Kconfig
> @@ -21,6 +21,7 @@ config VGA_SWITCHEROO
>  	bool "Laptop Hybrid Graphics - GPU switching support"
>  	depends on X86
>  	depends on ACPI
> +	depends on PCI
>  	select VGA_ARB
>  	help
>  	  Many laptops released in 2008/9/10 have two GPUs with a multiplexer
> -- 
> 2.19.0
>
Rafael J. Wysocki - Jan. 7, 2019, 10:53 a.m.
On Mon, Jan 7, 2019 at 11:34 AM Daniel Vetter <daniel@ffwll.ch> wrote:
>
> On Sun, Dec 30, 2018 at 07:56:04PM +0000, Sinan Kaya wrote:
> > This driver depends on the PCI infrastructure but the dependency has not
> > been explicitly called out.
> >
> > Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> > Signed-off-by: Sinan Kaya <okaya@kernel.org>
> > Reviewed-by: Lukas Wunner <lukas@wunner.de>
> > Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> I'm assuming this goes in through the acpi tree, correct?

I'm going to pick it up.

Patch

diff --git a/drivers/gpu/vga/Kconfig b/drivers/gpu/vga/Kconfig
index b677e5d524e6..d5f1d8e1c6f8 100644
--- a/drivers/gpu/vga/Kconfig
+++ b/drivers/gpu/vga/Kconfig
@@ -21,6 +21,7 @@  config VGA_SWITCHEROO
 	bool "Laptop Hybrid Graphics - GPU switching support"
 	depends on X86
 	depends on ACPI
+	depends on PCI
 	select VGA_ARB
 	help
 	  Many laptops released in 2008/9/10 have two GPUs with a multiplexer