Patchwork [-next] i5000_edac: remove set but not used variables 'maxdimmperch, maxch, channel_count'

login
register
mail settings
Submitter YueHaibing
Date Dec. 11, 2018, 9:52 a.m.
Message ID <20181211095207.25936-1-yuehaibing@huawei.com>
Download mbox | patch
Permalink /patch/677757/
State New
Headers show

Comments

YueHaibing - Dec. 11, 2018, 9:52 a.m.
Fixes gcc '-Wunused-but-set-variable' warning:

drivers/edac/i5000_edac.c: In function 'i5000_get_mc_regs':
drivers/edac/i5000_edac.c:1138:6: warning:
 variable 'maxdimmperch' set but not used [-Wunused-but-set-variable]

drivers/edac/i5000_edac.c:1137:6: warning:
 variable 'maxch' set but not used [-Wunused-but-set-variable]

drivers/edac/i5000_edac.c: In function 'i5000_init_csrows':
drivers/edac/i5000_edac.c:1256:13: warning:
 variable 'channel_count' set but not used [-Wunused-but-set-variable]

It never used since introduction in
commit eb60705ac5a9 ("drivers/edac: new intel 5000 MC driver")

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/edac/i5000_edac.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)
Borislav Petkov - Dec. 11, 2018, 1:58 p.m.
On Tue, Dec 11, 2018 at 05:52:07PM +0800, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/edac/i5000_edac.c: In function 'i5000_get_mc_regs':
> drivers/edac/i5000_edac.c:1138:6: warning:
>  variable 'maxdimmperch' set but not used [-Wunused-but-set-variable]
> 
> drivers/edac/i5000_edac.c:1137:6: warning:
>  variable 'maxch' set but not used [-Wunused-but-set-variable]
> 
> drivers/edac/i5000_edac.c: In function 'i5000_init_csrows':
> drivers/edac/i5000_edac.c:1256:13: warning:
>  variable 'channel_count' set but not used [-Wunused-but-set-variable]
> 
> It never used since introduction in
> commit eb60705ac5a9 ("drivers/edac: new intel 5000 MC driver")
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/edac/i5000_edac.c | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)

Applied, thanks.

Patch

diff --git a/drivers/edac/i5000_edac.c b/drivers/edac/i5000_edac.c
index 98bef13..078a735 100644
--- a/drivers/edac/i5000_edac.c
+++ b/drivers/edac/i5000_edac.c
@@ -1134,8 +1134,6 @@  static void i5000_get_mc_regs(struct mem_ctl_info *mci)
 	u32 actual_tolm;
 	u16 limit;
 	int slot_row;
-	int maxch;
-	int maxdimmperch;
 	int way0, way1;
 
 	pvt = mci->pvt_info;
@@ -1145,9 +1143,6 @@  static void i5000_get_mc_regs(struct mem_ctl_info *mci)
 	pci_read_config_dword(pvt->system_address, AMBASE + sizeof(u32),
 			&pvt->u.ambase_top);
 
-	maxdimmperch = pvt->maxdimmperch;
-	maxch = pvt->maxch;
-
 	edac_dbg(2, "AMBASE= 0x%lx  MAXCH= %d  MAX-DIMM-Per-CH= %d\n",
 		 (long unsigned int)pvt->ambase, pvt->maxch, pvt->maxdimmperch);
 
@@ -1253,7 +1248,7 @@  static int i5000_init_csrows(struct mem_ctl_info *mci)
 {
 	struct i5000_pvt *pvt;
 	struct dimm_info *dimm;
-	int empty, channel_count;
+	int empty;
 	int max_csrows;
 	int mtr;
 	int csrow_megs;
@@ -1261,8 +1256,6 @@  static int i5000_init_csrows(struct mem_ctl_info *mci)
 	int slot;
 
 	pvt = mci->pvt_info;
-
-	channel_count = pvt->maxch;
 	max_csrows = pvt->maxdimmperch * 2;
 
 	empty = 1;		/* Assume NO memory */