Patchwork [net,1/4] mlxsw: spectrum_nve: Remove easily triggerable warnings

mail settings
Submitter Ido Schimmel
Date Dec. 6, 2018, 5:44 p.m.
Message ID <>
Download mbox | patch
Permalink /patch/674489/
State New
Headers show


Ido Schimmel - Dec. 6, 2018, 5:44 p.m.
It is possible to trigger a warning in mlxsw in case a flood entry which
mlxsw is not aware of is deleted from the VxLAN device. This is because
mlxsw expects to find a singly linked list where the flood entry is
present in.

Fix by removing these warnings for now.

Will re-add them in the next release after we teach mlxsw to ask for a
dump of FDB entries from the VxLAN device, once it is enslaved to a
bridge mlxsw cares about.

Fixes: 6e6030bd5412 ("mlxsw: spectrum_nve: Implement common NVE core")
Signed-off-by: Ido Schimmel <>
Reviewed-by: Petr Machata <>
 drivers/net/ethernet/mellanox/mlxsw/spectrum_nve.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_nve.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_nve.c
index ad06d9969bc1..5c13674439f1 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_nve.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_nve.c
@@ -560,7 +560,7 @@  static void mlxsw_sp_nve_mc_list_ip_del(struct mlxsw_sp *mlxsw_sp,
 	mc_record = mlxsw_sp_nve_mc_record_find(mc_list, proto, addr,
-	if (WARN_ON(!mc_record))
+	if (!mc_record)
 	mlxsw_sp_nve_mc_record_entry_del(mc_record, mc_entry);
@@ -647,7 +647,7 @@  void mlxsw_sp_nve_flood_ip_del(struct mlxsw_sp *mlxsw_sp,
 	key.fid_index = mlxsw_sp_fid_index(fid);
 	mc_list = mlxsw_sp_nve_mc_list_find(mlxsw_sp, &key);
-	if (WARN_ON(!mc_list))
+	if (!mc_list)
 	mlxsw_sp_nve_fid_flood_index_clear(fid, mc_list);