Patchwork thermal: stm32: Fix stm_thermal_read_factory_settings

login
register
mail settings
Submitter David HERNANDEZ SANCHEZ
Date Dec. 6, 2018, 1:23 p.m.
Message ID <1544102603-14899-1-git-send-email-david.hernandezsanchez@st.com>
Download mbox | patch
Permalink /patch/674171/
State New
Headers show

Comments

David HERNANDEZ SANCHEZ - Dec. 6, 2018, 1:23 p.m.
Adding brackets allows to multiply the register value,
masked by TS1_RAMP_COEFF_MASK, by an ADJUST value
properly and not to multiply ADJUST by register value and
then mask the whole.

Signed-off-by: David Hernandez Sanchez <david.hernandezsanchez@st.com>

Fixes: 1d693155 ("thermal: add stm32 thermal driver")

-- 
2.7.4
Daniel Lezcano - Dec. 6, 2018, 1:30 p.m.
On 06/12/2018 14:23, David HERNANDEZ SANCHEZ wrote:
> Adding brackets allows to multiply the register value,
> masked by TS1_RAMP_COEFF_MASK, by an ADJUST value
> properly and not to multiply ADJUST by register value and
> then mask the whole.
> 
> Signed-off-by: David Hernandez Sanchez <david.hernandezsanchez@st.com>
> Fixes: 1d693155 ("thermal: add stm32 thermal driver")

Usually 'Fixes' comes first in the list.

Other than that:

Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>

> diff --git a/drivers/thermal/st/stm_thermal.c b/drivers/thermal/st/stm_thermal.c
> index daa1257..bbd73c5 100644
> --- a/drivers/thermal/st/stm_thermal.c
> +++ b/drivers/thermal/st/stm_thermal.c
> @@ -241,8 +241,8 @@ static int stm_thermal_read_factory_settings(struct stm_thermal_sensor *sensor)
>  		sensor->t0 = TS1_T0_VAL1;
>  
>  	/* Retrieve fmt0 and put it on Hz */
> -	sensor->fmt0 = ADJUST * readl_relaxed(sensor->base + DTS_T0VALR1_OFFSET)
> -					      & TS1_FMT0_MASK;
> +	sensor->fmt0 = ADJUST * (readl_relaxed(sensor->base +
> +				 DTS_T0VALR1_OFFSET) & TS1_FMT0_MASK);
>  
>  	/* Retrieve ramp coefficient */
>  	sensor->ramp_coeff = readl_relaxed(sensor->base + DTS_RAMPVALR_OFFSET) &
>

Patch

diff --git a/drivers/thermal/st/stm_thermal.c b/drivers/thermal/st/stm_thermal.c

index daa1257..bbd73c5 100644

--- a/drivers/thermal/st/stm_thermal.c

+++ b/drivers/thermal/st/stm_thermal.c

@@ -241,8 +241,8 @@  static int stm_thermal_read_factory_settings(struct stm_thermal_sensor *sensor)

 		sensor->t0 = TS1_T0_VAL1;
 
 	/* Retrieve fmt0 and put it on Hz */
-	sensor->fmt0 = ADJUST * readl_relaxed(sensor->base + DTS_T0VALR1_OFFSET)

-					      & TS1_FMT0_MASK;

+	sensor->fmt0 = ADJUST * (readl_relaxed(sensor->base +

+				 DTS_T0VALR1_OFFSET) & TS1_FMT0_MASK);

 
 	/* Retrieve ramp coefficient */
 	sensor->ramp_coeff = readl_relaxed(sensor->base + DTS_RAMPVALR_OFFSET) &