Patchwork dsa device tree bindings: fix typo and wrong example

login
register
mail settings
Submitter Pavel Machek
Date Dec. 6, 2018, 1:05 p.m.
Message ID <20181206130513.GE22343@amd>
Download mbox | patch
Permalink /patch/674109/
State New
Headers show

Comments

Pavel Machek - Dec. 6, 2018, 1:05 p.m.
Fix typo and fix compatible value that is not actually permitted by the
description in the example.
   
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Michal Vokáč - Dec. 6, 2018, 1:28 p.m.
On 6.12.2018 14:05, Pavel Machek wrote:
>      
> Fix typo and fix compatible value that is not actually permitted by the
> description in the example.

Ahoj Pavle, I think the subject should be more like:

	"dt-bindings: net: dsa: ..."

BR, Michal

>     
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
> 
> diff --git a/Documentation/devicetree/bindings/net/dsa/marvell.txt b/Documentation/devicetree/bindings/net/dsa/marvell.txt
> index feb007af13cb..abf1be036ac5 100644
> --- a/Documentation/devicetree/bindings/net/dsa/marvell.txt
> +++ b/Documentation/devicetree/bindings/net/dsa/marvell.txt
> @@ -41,7 +41,7 @@ Optional properties:
>   - mdio			: Container of PHY and devices on the switches MDIO
>   			  bus.
>   - mdio?		: Container of PHYs and devices on the external MDIO
> -			  bus. The node must contains a compatible string of
> +			  bus. The node must contain a compatible string of
>   			  "marvell,mv88e6xxx-mdio-external"
>   
>   Example:
> @@ -80,7 +80,7 @@ Example:
>   		#interrupt-cells = <2>;
>   
>   		switch0: switch@0 {
> -			compatible = "marvell,mv88e6390";
> +			compatible = "marvell,mv88e6190";
>   			reg = <0>;
>   			reset-gpios = <&gpio5 1 GPIO_ACTIVE_LOW>;
>   
> 
>

Patch

diff --git a/Documentation/devicetree/bindings/net/dsa/marvell.txt b/Documentation/devicetree/bindings/net/dsa/marvell.txt
index feb007af13cb..abf1be036ac5 100644
--- a/Documentation/devicetree/bindings/net/dsa/marvell.txt
+++ b/Documentation/devicetree/bindings/net/dsa/marvell.txt
@@ -41,7 +41,7 @@  Optional properties:
 - mdio			: Container of PHY and devices on the switches MDIO
 			  bus.
 - mdio?		: Container of PHYs and devices on the external MDIO
-			  bus. The node must contains a compatible string of
+			  bus. The node must contain a compatible string of
 			  "marvell,mv88e6xxx-mdio-external"
 
 Example:
@@ -80,7 +80,7 @@  Example:
 		#interrupt-cells = <2>;
 
 		switch0: switch@0 {
-			compatible = "marvell,mv88e6390";
+			compatible = "marvell,mv88e6190";
 			reg = <0>;
 			reset-gpios = <&gpio5 1 GPIO_ACTIVE_LOW>;