Patchwork [driver-core,v8,7/9] driver core: Attach devices on CPU local to device node

login
register
mail settings
Submitter Alexander Duyck
Date Dec. 5, 2018, 5:25 p.m.
Message ID <154403074977.11544.13408447599624293705.stgit@ahduyck-desk1.jf.intel.com>
Download mbox | patch
Permalink /patch/673381/
State New
Headers show

Comments

Alexander Duyck - Dec. 5, 2018, 5:25 p.m.
Call the asynchronous probe routines on a CPU local to the device node. By
doing this we should be able to improve our initialization time
significantly as we can avoid having to access the device from a remote
node which may introduce higher latency.

For example, in the case of initializing memory for NVDIMM this can have a
significant impact as initialing 3TB on remote node can take up to 39
seconds while initialing it on a local node only takes 23 seconds. It is
situations like this where we will see the biggest improvement.

Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
---
 drivers/base/dd.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Patch

diff --git a/drivers/base/dd.c b/drivers/base/dd.c
index b731741059cb..49096adf96a1 100644
--- a/drivers/base/dd.c
+++ b/drivers/base/dd.c
@@ -833,7 +833,7 @@  static int __device_attach(struct device *dev, bool allow_async)
 			 */
 			dev_dbg(dev, "scheduling asynchronous probe\n");
 			get_device(dev);
-			async_schedule(__device_attach_async_helper, dev);
+			async_schedule_dev(__device_attach_async_helper, dev);
 		} else {
 			pm_request_idle(dev);
 		}
@@ -993,7 +993,7 @@  static int __driver_attach(struct device *dev, void *data)
 		if (!dev->driver) {
 			get_device(dev);
 			dev->p->async_driver = drv;
-			async_schedule(__driver_attach_async_helper, dev);
+			async_schedule_dev(__driver_attach_async_helper, dev);
 		}
 		device_unlock(dev);
 		return 0;