Patchwork [v5,1/4] arm64: arm_pmu: remove unnecessary isb instruction

mail settings
Submitter Andrew Murray
Date Dec. 5, 2018, 3:30 p.m.
Message ID <>
Download mbox | patch
Permalink /patch/673203/
State New
Headers show


Andrew Murray - Dec. 5, 2018, 3:30 p.m.
The armv8pmu_enable_event_counter function issues an isb instruction
after enabling a pair of counters - this doesn't provide any value
and is inconsistent with the armv8pmu_disable_event_counter.

In any case armv8pmu_enable_event_counter is always called with the
PMU stopped. Starting the PMU with armv8pmu_start results in an isb
instruction being issued prior to writing to PMCR_EL0.

Let's remove the unnecessary isb instruction.

Signed-off-by: Andrew Murray <>
Reviewed-by: Suzuki K Poulose <>
Acked-by: Mark Rutland <>
 arch/arm64/kernel/perf_event.c | 1 -
 1 file changed, 1 deletion(-)


diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c
index 8e38d52..de564ae 100644
--- a/arch/arm64/kernel/perf_event.c
+++ b/arch/arm64/kernel/perf_event.c
@@ -652,7 +652,6 @@  static inline void armv8pmu_enable_event_counter(struct perf_event *event)
 	if (armv8pmu_event_is_chained(event))
 		armv8pmu_enable_counter(idx - 1);
-	isb();
 static inline int armv8pmu_disable_counter(int idx)