Patchwork [dpdk-dev] devtools: fix symbol check when adding experimental section

login
register
mail settings
Submitter Gao Feng
Date Dec. 5, 2018, 2:50 a.m.
Message ID <1543978226-23480-2-git-send-email-gfree.wind@vip.163.com>
Download mbox | patch
Permalink /patch/672513/
State New
Headers show

Comments

Gao Feng - Dec. 5, 2018, 2:50 a.m.
From: David Marchand <david.marchand@redhat.com>

The incriminated commit did relax the condition to catch all sections
but dropped the + removal which can trigger false detection of the
special EXPERIMENTAL section when adding symbols and the section in the
same patch.

Fixes: 7281cf520f89 ("devtools: relax rule for identifying symbol section")
Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
---
 devtools/check-symbol-change.sh | 1 +
 1 file changed, 1 insertion(+)
Gao Feng - Dec. 5, 2018, 3:46 a.m.
Sorry for the noise. Please ignore this reply.

It is caused by wrong command.

Best Regards
Feng

At 2018-12-05 10:50:26, "" <gfree.wind@vip.163.com> wrote:
>From: David Marchand <david.marchand@redhat.com>
>
>The incriminated commit did relax the condition to catch all sections
>but dropped the + removal which can trigger false detection of the
>special EXPERIMENTAL section when adding symbols and the section in the
>same patch.
>
>Fixes: 7281cf520f89 ("devtools: relax rule for identifying symbol section")
>Cc: stable@dpdk.org
>
>Signed-off-by: David Marchand <david.marchand@redhat.com>
>Acked-by: Neil Horman <nhorman@tuxdriver.com>
>---
> devtools/check-symbol-change.sh | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
>index 4b8d9f3..020da7e 100755
>--- a/devtools/check-symbol-change.sh
>+++ b/devtools/check-symbol-change.sh
>@@ -31,6 +31,7 @@ build_map_changes()
> 		# Triggering this rule sets in_sec to 1, which actives the
> 		# symbol rule below
> 		/^.*{/ {
>+			gsub("+", "");
> 			if (in_map == 1) {
> 				sec=$(NF-1); in_sec=1;
> 			}
>-- 
>2.7.4
>
>

Patch

diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
index 4b8d9f3..020da7e 100755
--- a/devtools/check-symbol-change.sh
+++ b/devtools/check-symbol-change.sh
@@ -31,6 +31,7 @@  build_map_changes()
 		# Triggering this rule sets in_sec to 1, which actives the
 		# symbol rule below
 		/^.*{/ {
+			gsub("+", "");
 			if (in_map == 1) {
 				sec=$(NF-1); in_sec=1;
 			}