Patchwork WIP: UFS on apq8098

login
register
mail settings
Submitter Marc Gonzalez
Date Dec. 3, 2018, 4:22 p.m.
Message ID <0276ecdc-98cf-7342-4b12-ddcaec4aa21c@free.fr>
Download mbox | patch
Permalink /patch/670867/
State New
Headers show

Comments

Marc Gonzalez - Dec. 3, 2018, 4:22 p.m.
On 03/12/2018 17:18, Jeffrey Hugo wrote:

> Ok.  Then its non-obvious to me why you are getting the ref clock error.

Sorry for being unclear, the issue was resolved with
(as specified in Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt)



PHY init seems to work now:

[    1.000150] qcom-qmp-phy 1da7000.phy: Linked as a consumer to regulator.15
[    1.000256] qcom-qmp-phy 1da7000.phy: Linked as a consumer to regulator.16
[    1.000882] qcom-qmp-phy 1da7000.phy: Registered Qcom-QMP phy

Moving on to MAC init errors :-)

[    2.314303] ufshcd-qcom 1da4000.ufshc: ufshcd_get_vreg: vdd-hba get failed, err=-517
[    2.314530] ufshcd-qcom 1da4000.ufshc: Initialization failed
[    2.376216] ufshcd-qcom 1da4000.ufshc: ufshcd_pltfrm_init() failed -517

(I do note that sdm845 does not define the vdd-hba-supply prop.)

Regards.

Patch

diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
index 10e7b8a55b8a..b5b2b05bc782 100644
--- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
@@ -745,12 +745,8 @@ 
                        #address-cells = <1>;
                        #size-cells = <1>;
                        ranges;
-                       clock-names =
-                               "ref_clk_src",
-                               "ref_clk",
-                               "ref_aux_clk";
+                       clock-names = "ref", "ref_aux";
                        clocks =
-                               <&rpmcc 0>,
                                <&gcc GCC_UFS_CLKREF_CLK>,
                                <&gcc GCC_UFS_PHY_AUX_CLK>;