Patchwork [PATCHv3,4/4] misc: pci_endpoint_test: Add the layerscape EP device support

login
register
mail settings
Submitter Bao Xiaowei
Date Dec. 3, 2018, 10:35 a.m.
Message ID <20181203103505.46885-4-xiaowei.bao@nxp.com>
Download mbox | patch
Permalink /patch/670441/
State New
Headers show

Comments

Bao Xiaowei - Dec. 3, 2018, 10:35 a.m.
Add the layerscape EP device support in pci_endpoint_test driver.

Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com>
---
v2:
 - no change
v3:
 - no change

 drivers/misc/pci_endpoint_test.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Greg Kroah-Hartman - Dec. 19, 2018, 9:21 a.m.
On Mon, Dec 03, 2018 at 06:35:05PM +0800, Xiaowei Bao wrote:
> Add the layerscape EP device support in pci_endpoint_test driver.
> 
> Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com>
> ---
> v2:
>  - no change
> v3:
>  - no change
> 
>  drivers/misc/pci_endpoint_test.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c
> index 896e2df..744d10c 100644
> --- a/drivers/misc/pci_endpoint_test.c
> +++ b/drivers/misc/pci_endpoint_test.c
> @@ -788,6 +788,8 @@ static void pci_endpoint_test_remove(struct pci_dev *pdev)
>  static const struct pci_device_id pci_endpoint_test_tbl[] = {
>  	{ PCI_DEVICE(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_DRA74x) },
>  	{ PCI_DEVICE(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_DRA72x) },
> +	/* 0x81c0: The device id of ls1046a in NXP. */

There is no need for a comment, just this line is fine:

> +	{ PCI_DEVICE(PCI_VENDOR_ID_FREESCALE, 0x81c0) },

If you note, no other lines have comments.

If you want to say that this is a specific device, then use a #define
with that device name and then use that define here, like the
PCI_DEVICE_ID_TI_DRA72x was done.

thanks,

greg k-h
Bao Xiaowei - Dec. 19, 2018, 9:30 a.m.
-----Original Message-----
From: Greg KH <gregkh@linuxfoundation.org> 

Sent: 2018年12月19日 17:21
To: Xiaowei Bao <xiaowei.bao@nxp.com>
Cc: bhelgaas@google.com; robh+dt@kernel.org; mark.rutland@arm.com; shawnguo@kernel.org; Leo Li <leoyang.li@nxp.com>; kishon@ti.com; lorenzo.pieralisi@arm.com; arnd@arndb.de; M.h. Lian <minghuan.lian@nxp.com>; Mingkai Hu <mingkai.hu@nxp.com>; Roy Zang <roy.zang@nxp.com>; kstewart@linuxfoundation.org; cyrille.pitchen@free-electrons.com; pombredanne@nexb.com; shawn.lin@rock-chips.com; niklas.cassel@axis.com; linux-pci@vger.kernel.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCHv3 4/4] misc: pci_endpoint_test: Add the layerscape EP device support

On Mon, Dec 03, 2018 at 06:35:05PM +0800, Xiaowei Bao wrote:
> Add the layerscape EP device support in pci_endpoint_test driver.

> 

> Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com>

> ---

> v2:

>  - no change

> v3:

>  - no change

> 

>  drivers/misc/pci_endpoint_test.c |    2 ++

>  1 files changed, 2 insertions(+), 0 deletions(-)

> 

> diff --git a/drivers/misc/pci_endpoint_test.c 

> b/drivers/misc/pci_endpoint_test.c

> index 896e2df..744d10c 100644

> --- a/drivers/misc/pci_endpoint_test.c

> +++ b/drivers/misc/pci_endpoint_test.c

> @@ -788,6 +788,8 @@ static void pci_endpoint_test_remove(struct 

> pci_dev *pdev)  static const struct pci_device_id pci_endpoint_test_tbl[] = {

>  	{ PCI_DEVICE(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_DRA74x) },

>  	{ PCI_DEVICE(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_DRA72x) },

> +	/* 0x81c0: The device id of ls1046a in NXP. */


There is no need for a comment, just this line is fine:

> +	{ PCI_DEVICE(PCI_VENDOR_ID_FREESCALE, 0x81c0) },


If you note, no other lines have comments.

If you want to say that this is a specific device, then use a #define with that device name and then use that define here, like the PCI_DEVICE_ID_TI_DRA72x was done.

thanks,

greg k-h
[Xiaowei Bao] Hi Greg, OK, I can remove the comments in the next version patch.

Patch

diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c
index 896e2df..744d10c 100644
--- a/drivers/misc/pci_endpoint_test.c
+++ b/drivers/misc/pci_endpoint_test.c
@@ -788,6 +788,8 @@  static void pci_endpoint_test_remove(struct pci_dev *pdev)
 static const struct pci_device_id pci_endpoint_test_tbl[] = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_DRA74x) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_DRA72x) },
+	/* 0x81c0: The device id of ls1046a in NXP. */
+	{ PCI_DEVICE(PCI_VENDOR_ID_FREESCALE, 0x81c0) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_SYNOPSYS, 0xedda) },
 	{ }
 };