Patchwork [dpdk-dev] librte_ethdev: Fix typo in error message of invalid nb_rx_desc or nb_tx_desc

login
register
mail settings
Submitter Yaroslav Brustinov (ybrustin)
Date Dec. 3, 2018, 9:54 a.m.
Message ID <1543830844-30343-1-git-send-email-ybrustin@cisco.com>
Download mbox | patch
Permalink /patch/670327/
State New
Headers show

Comments

Yaroslav Brustinov (ybrustin) - Dec. 3, 2018, 9:54 a.m.
Signed-off-by: Yaroslav Brustinov <ybrustin@cisco.com>
---
 lib/librte_ethdev/rte_ethdev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Ferruh Yigit - Dec. 11, 2018, 4:42 p.m.
On 12/3/2018 9:54 AM, Yaroslav Brustinov wrote:
> Signed-off-by: Yaroslav Brustinov <ybrustin@cisco.com>

Updated commit log as following:
    ethdev: fix typo in error message in queue setup

    '=' should be '>=" for '[rt]x_desc_lim.nb_min' check.

    Fixes: 386c993e95f1 ("ethdev: add a missing sanity check for Tx queue setup")
    Fixes: 80a1deb4c77a ("ethdev: add API to retrieve queue information")
    Cc: stable@dpdk.org

    Signed-off-by: Yaroslav Brustinov <ybrustin@cisco.com>


Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/master, thanks.

Patch

diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
index 5f85817..9d5107d 100644
--- a/lib/librte_ethdev/rte_ethdev.c
+++ b/lib/librte_ethdev/rte_ethdev.c
@@ -1594,7 +1594,7 @@  rte_eth_rx_queue_setup(uint16_t port_id, uint16_t rx_queue_id,
 			nb_rx_desc % dev_info.rx_desc_lim.nb_align != 0) {
 
 		RTE_ETHDEV_LOG(ERR,
-			"Invalid value for nb_rx_desc(=%hu), should be: <= %hu, = %hu, and a product of %hu\n",
+			"Invalid value for nb_rx_desc(=%hu), should be: <= %hu, >= %hu, and a product of %hu\n",
 			nb_rx_desc, dev_info.rx_desc_lim.nb_max,
 			dev_info.rx_desc_lim.nb_min,
 			dev_info.rx_desc_lim.nb_align);
@@ -1698,7 +1698,7 @@  rte_eth_tx_queue_setup(uint16_t port_id, uint16_t tx_queue_id,
 	    nb_tx_desc < dev_info.tx_desc_lim.nb_min ||
 	    nb_tx_desc % dev_info.tx_desc_lim.nb_align != 0) {
 		RTE_ETHDEV_LOG(ERR,
-			"Invalid value for nb_tx_desc(=%hu), should be: <= %hu, = %hu, and a product of %hu\n",
+			"Invalid value for nb_tx_desc(=%hu), should be: <= %hu, >= %hu, and a product of %hu\n",
 			nb_tx_desc, dev_info.tx_desc_lim.nb_max,
 			dev_info.tx_desc_lim.nb_min,
 			dev_info.tx_desc_lim.nb_align);