Submitter | Christoph Hellwig |
---|---|
Date | Nov. 30, 2018, 1:22 p.m. |
Message ID | <20181130132231.16512-24-hch@lst.de> |
Download | mbox | patch |
Permalink | /patch/669079/ |
State | New |
Headers | show
Return-Path: <iommu-bounces@lists.linux-foundation.org> Received: from smtp.codeaurora.org (pdx-caf-mail.web.codeaurora.org [172.30.200.26]) by pdx-caf-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1BE026046E for <patchwork-iommu@patchwork.codeaurora.org>; Fri, 30 Nov 2018 13:25:37 +0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1000) id EB2E161670; Fri, 30 Nov 2018 13:25:30 +0000 (UTC) Authentication-Results: smtp.codeaurora.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="YI7mlrYC" X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.codeaurora.org (Postfix) with ESMTPS id 5E70B61653 for <patchwork-iommu@patchwork.codeaurora.org>; Fri, 30 Nov 2018 13:25:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 5E70B61653 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 1D107BAA; Fri, 30 Nov 2018 13:24:15 +0000 (UTC) X-Original-To: iommu@lists.linux-foundation.org Delivered-To: iommu@mail.linuxfoundation.org Received: from smtp2.linuxfoundation.org (smtp2.linux-foundation.org [172.17.192.36]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 96242BA3 for <iommu@lists.linux-foundation.org>; Fri, 30 Nov 2018 13:24:13 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by smtp2.linuxfoundation.org (Postfix) with ESMTPS id 419641DD19 for <iommu@lists.linux-foundation.org>; Fri, 30 Nov 2018 13:24:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=GpxuU5NMbQU4Wkc8ZKHKSzkrwQNnxYoYUsxGInbTqJI=; b=YI7mlrYCbVJ+jK6g2JY+SFG38O wWXh6AKYVzcAk3wLIXzDeUVeTZvdQLrU89XK77IpfyY/uWB791aoc5nSdSYK4fcXdca/hWYUUZ7Sx 3wmcpgRtUw4zspgsHWm+5oamGkUWk6hxtxg8653SzEDMC2s3jhkV2+hAdsfupqmCfZcoe13Zh6dFo ycm+hg461cGsrcFrutKM69CLCy9KeuluYsukAS1VOy1+9MDnulKnuRtiHlHzx33DT/PVHRUXwRnft zLz7Ptub7hpCkQjDq+H3efciK0ye4KGAYAdGig+hSMsMaiy+cjUwnFE3ItFm3Xl5HPxfcJoaCfETz iaaWcHMw==; Received: from 089144206221.atnat0015.highway.bob.at ([89.144.206.221] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gSim8-0005Bp-BI; Fri, 30 Nov 2018 13:24:08 +0000 From: Christoph Hellwig <hch@lst.de> To: iommu@lists.linux-foundation.org Subject: [PATCH 23/23] dma-mapping: return an error code from dma_mapping_error Date: Fri, 30 Nov 2018 14:22:31 +0100 Message-Id: <20181130132231.16512-24-hch@lst.de> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181130132231.16512-1-hch@lst.de> References: <20181130132231.16512-1-hch@lst.de> MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html Cc: linux-arch@vger.kernel.org, linux-alpha@vger.kernel.org, linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org, Linus Torvalds <torvalds@linux-foundation.org>, x86@kernel.org, Robin Murphy <robin.murphy@arm.com>, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, David Woodhouse <dwmw2@infradead.org>, linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support <iommu.lists.linux-foundation.org> List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/iommu>, <mailto:iommu-request@lists.linux-foundation.org?subject=unsubscribe> List-Archive: <http://lists.linuxfoundation.org/pipermail/iommu/> List-Post: <mailto:iommu@lists.linux-foundation.org> List-Help: <mailto:iommu-request@lists.linux-foundation.org?subject=help> List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/iommu>, <mailto:iommu-request@lists.linux-foundation.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org |
Comments
Patch
diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h index 2adef56c6069..b5bd25fc1f81 100644 --- a/include/linux/dma-mapping.h +++ b/include/linux/dma-mapping.h @@ -576,7 +576,7 @@ static inline int dma_mapping_error(struct device *dev, dma_addr_t dma_addr) { debug_dma_mapping_error(dev, dma_addr); if (dma_addr == DMA_MAPPING_ERROR) - return 1; + return -ENOMEM; return 0; }
Currently dma_mapping_error returns a boolean as int, with 1 meaning error. This is rather unusual and many callers have to convert it to errno value. The callers are highly inconsistent with error codes ranging from -ENOMEM over -EIO, -EINVAL and -EFAULT ranging to -EAGAIN. Return -ENOMEM which seems to be what the largest number of callers convert it to, and which also matches the typical error case where we are out of resources. Signed-off-by: Christoph Hellwig <hch@lst.de> --- include/linux/dma-mapping.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)