Patchwork PCI: Add missing include to drivers/pci.h

login
register
mail settings
Submitter Alexandru Gagniuc
Date Nov. 28, 2018, 10:28 p.m.
Message ID <20181128222805.12637-1-mr.nuke.me@gmail.com>
Download mbox | patch
Permalink /patch/667509/
State New
Headers show

Comments

Alexandru Gagniuc - Nov. 28, 2018, 10:28 p.m.
This files makes use of definitions provided in <linux/pci.h>. This
only compiles when <linux/pci.h> is included beforehand, and creates
a nasty include dependency. Instead, just include the correct file.

Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
---
 drivers/pci/pci.h | 2 ++
 1 file changed, 2 insertions(+)
Bjorn Helgaas - Dec. 6, 2018, 8:56 p.m.
On Wed, Nov 28, 2018 at 04:28:04PM -0600, Alexandru Gagniuc wrote:
> This files makes use of definitions provided in <linux/pci.h>. This
> only compiles when <linux/pci.h> is included beforehand, and creates
> a nasty include dependency. Instead, just include the correct file.
> 
> Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>

Applied to pci/misc for v4.21, thanks!

> ---
>  drivers/pci/pci.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
> index 662b7457db23..224d88634115 100644
> --- a/drivers/pci/pci.h
> +++ b/drivers/pci/pci.h
> @@ -2,6 +2,8 @@
>  #ifndef DRIVERS_PCI_H
>  #define DRIVERS_PCI_H
>  
> +#include <linux/pci.h>
> +
>  #define PCI_FIND_CAP_TTL	48
>  
>  #define PCI_VSEC_ID_INTEL_TBT	0x1234	/* Thunderbolt */
> -- 
> 2.17.1
>

Patch

diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
index 662b7457db23..224d88634115 100644
--- a/drivers/pci/pci.h
+++ b/drivers/pci/pci.h
@@ -2,6 +2,8 @@ 
 #ifndef DRIVERS_PCI_H
 #define DRIVERS_PCI_H
 
+#include <linux/pci.h>
+
 #define PCI_FIND_CAP_TTL	48
 
 #define PCI_VSEC_ID_INTEL_TBT	0x1234	/* Thunderbolt */