| Submitter | Dan Carpenter |
|---|---|
| Date | Nov. 27, 2018, 11:32 a.m. |
| Message ID | <20181127113235.7mxd7cxojtzbkbid@kili.mountain> |
| Download | mbox | patch |
| Permalink | /patch/665829/ |
| State | New |
| Headers | show |
Comments
On Tue, Nov 27, 2018 at 02:32:35PM +0300, Dan Carpenter wrote: > I've removed the 0x prefix for the row and col because the %#x format > already adds a 0x. Pls use passive tone in your commit message: no "we" or "I", etc. Also, pls read section "2) Describe your changes" in Documentation/process/submitting-patches.rst.
On Tue, Nov 27, 2018 at 01:49:15PM +0100, Borislav Petkov wrote: > On Tue, Nov 27, 2018 at 02:32:35PM +0300, Dan Carpenter wrote: > > I've removed the 0x prefix for the row and col because the %#x format > > already adds a 0x. > > Pls use passive tone in your commit message: no "we" or "I", etc. > > Also, pls read section "2) Describe your changes" in > Documentation/process/submitting-patches.rst. > I don't agree with all the style nit-picking these days. I think a competent programmer can understand the commit message so it's fine. I'm not going to resend, sorry. Just give me the Reported-by tag and re-write it how you want. regards, dan carpenter
On Tue, Nov 27, 2018 at 04:24:30PM +0300, Dan Carpenter wrote: > I don't agree with all the style nit-picking these days. I think a > competent programmer can understand the commit message so it's fine. > I'm not going to resend, sorry. That is your choice, of course. > Just give me the Reported-by tag and re-write it how you want. Well, it is my choice to not do the work for you so if anyone else rewrites it, I'll pick it up.
On Tue, Nov 27, 2018 at 02:27:55PM +0100, Borislav Petkov wrote: > On Tue, Nov 27, 2018 at 04:24:30PM +0300, Dan Carpenter wrote: > > I don't agree with all the style nit-picking these days. I think a > > competent programmer can understand the commit message so it's fine. > > I'm not going to resend, sorry. > > That is your choice, of course. > > > Just give me the Reported-by tag and re-write it how you want. > > Well, it is my choice to not do the work for you so if anyone else > rewrites it, I'll pick it up. > Qiuxu, can you take care of this? regards, dan carpenter
On Tue, Nov 27, 2018 at 04:31:52PM +0300, Dan Carpenter wrote: > On Tue, Nov 27, 2018 at 02:27:55PM +0100, Borislav Petkov wrote: > > On Tue, Nov 27, 2018 at 04:24:30PM +0300, Dan Carpenter wrote: > > > I don't agree with all the style nit-picking these days. I think a > > > competent programmer can understand the commit message so it's fine. > > > I'm not going to resend, sorry. > > > > That is your choice, of course. > > > > > Just give me the Reported-by tag and re-write it how you want. > > > > Well, it is my choice to not do the work for you so if anyone else > > rewrites it, I'll pick it up. > > > > Qiuxu, can you take care of this? > Qiuxu, it's not fair for me to involve you in this stupid spat with Boris. I appologize. I will resend tomorrow. regards, dan carpenter
On Tue, Nov 27, 2018 at 04:53:35PM +0300, Dan Carpenter wrote: > Qiuxu, it's not fair for me to involve you in this stupid spat with > Boris. That's not a spat - it is simply a difference of opinions. And I accept your opinion - I just don't agree with it.
Patch
diff --git a/drivers/edac/skx_edac.c b/drivers/edac/skx_edac.c index 93ef161bb5e1..354d2a4b2c64 100644 --- a/drivers/edac/skx_edac.c +++ b/drivers/edac/skx_edac.c @@ -389,7 +389,7 @@ static int get_dimm_info(u32 mtr, u32 amap, struct dimm_info *dimm, size = ((1ull << (rows + cols + ranks)) * banks) >> (20 - 3); npages = MiB_TO_PAGES(size); - edac_dbg(0, "mc#%d: channel %d, dimm %d, %lld MiB (%d pages) bank: %d, rank: %d, row: 0x%#x, col: 0x%#x\n", + edac_dbg(0, "mc#%d: channel %d, dimm %d, %lld MiB (%d pages) bank: %d, rank: %d, row: %#x, col: %#x\n", imc->mc, chan, dimmno, size, npages, banks, 1 << ranks, rows, cols);
I've removed the 0x prefix for the row and col because the %#x format already adds a 0x. Fixes: e235dd43d8b0 ("EDAC, skx: Prepend hex formatting with '0x'") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/edac/skx_edac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)