Patchwork [v11,3/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdlien from kexec

login
register
mail settings
Submitter Borislav Petkov
Date Nov. 13, 2018, 9:51 p.m.
Message ID <20181113215156.GP10502@zn.tnic>
Download mbox | patch
Permalink /patch/656147/
State New
Headers show

Comments

Borislav Petkov - Nov. 13, 2018, 9:51 p.m.
On Tue, Nov 13, 2018 at 03:06:16PM -0500, Masayoshi Mizuma wrote:
> I just felt the BOOT_STRING thing in lib/kstrtox.c confuses...
> I'm OK for now if it's applied your below comment.

Well, actually, upon a second look, I don't think that including a .c
file into a header is ok:


Chao, why isn't this part of arch/x86/boot/compressed/misc.c ?

Patch

diff --git a/arch/x86/boot/string.h b/arch/x86/boot/string.h
index 3d78e27077f4..0ff3edb888e4 100644
--- a/arch/x86/boot/string.h
+++ b/arch/x86/boot/string.h
@@ -30,3 +30,7 @@  extern unsigned long long simple_strtoull(const char *cp, char **endp,
                                          unsigned int base);

 #endif /* BOOT_STRING_H */
+
+#ifdef BOOT_STRING
+#include "../../../lib/kstrtox.c"
+#endif