Patchwork [2/5] dmaengine: sprd: remove dma_slave_config direction usage

login
register
mail settings
Submitter Vinod Koul
Date Nov. 11, 2018, 3:47 p.m.
Message ID <20181111154710.26904-3-vkoul@kernel.org>
Download mbox | patch
Permalink /patch/654181/
State New
Headers show

Comments

Vinod Koul - Nov. 11, 2018, 3:47 p.m.
dma_slave_config direction was marked as deprecated quite some
time back, remove the usage from this driver so that the field
can be removed

Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
 drivers/dma/sprd-dma.c | 3 ---
 1 file changed, 3 deletions(-)
Baolin Wang - Nov. 12, 2018, 2:47 a.m.
Hi Vinod,

On 11 November 2018 at 23:47, Vinod Koul <vkoul@kernel.org> wrote:
> dma_slave_config direction was marked as deprecated quite some
> time back, remove the usage from this driver so that the field
> can be removed
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>

We already posted one patch set to fix this issue, could you have a
look when you feel free? Thanks.

https://lore.kernel.org/patchwork/patch/1007238/
https://lore.kernel.org/patchwork/project/lkml/list/?series=371812

> ---
>  drivers/dma/sprd-dma.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c
> index 38d4e4f07c66..c226dc93e401 100644
> --- a/drivers/dma/sprd-dma.c
> +++ b/drivers/dma/sprd-dma.c
> @@ -847,9 +847,6 @@ static int sprd_dma_slave_config(struct dma_chan *chan,
>         struct sprd_dma_chn *schan = to_sprd_dma_chan(chan);
>         struct dma_slave_config *slave_cfg = &schan->slave_cfg;
>
> -       if (!is_slave_direction(config->direction))
> -               return -EINVAL;
> -
>         memcpy(slave_cfg, config, sizeof(*config));
>         return 0;
>  }
> --
> 2.14.4
>
Vinod Koul - Nov. 12, 2018, 6:06 p.m.
On 12-11-18, 10:47, Baolin Wang wrote:
> Hi Vinod,
> 
> On 11 November 2018 at 23:47, Vinod Koul <vkoul@kernel.org> wrote:
> > dma_slave_config direction was marked as deprecated quite some
> > time back, remove the usage from this driver so that the field
> > can be removed
> >
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> 
> We already posted one patch set to fix this issue, could you have a
> look when you feel free? Thanks.

Thanks for fixing that, I will check the series and drop this one

Patch

diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c
index 38d4e4f07c66..c226dc93e401 100644
--- a/drivers/dma/sprd-dma.c
+++ b/drivers/dma/sprd-dma.c
@@ -847,9 +847,6 @@  static int sprd_dma_slave_config(struct dma_chan *chan,
 	struct sprd_dma_chn *schan = to_sprd_dma_chan(chan);
 	struct dma_slave_config *slave_cfg = &schan->slave_cfg;
 
-	if (!is_slave_direction(config->direction))
-		return -EINVAL;
-
 	memcpy(slave_cfg, config, sizeof(*config));
 	return 0;
 }