Patchwork EDAC: Don't add devices under /sys/bus/edac

login
register
mail settings
Submitter Borislav Petkov
Date Nov. 6, 2018, 2:45 p.m.
Message ID <20181106144535.GI13712@zn.tnic>
Download mbox | patch
Permalink /patch/650607/
State New
Headers show

Comments

Borislav Petkov - Nov. 6, 2018, 2:45 p.m.
On Tue, Oct 02, 2018 at 06:26:08PM +0200, Borislav Petkov wrote:
> On Tue, Oct 02, 2018 at 03:51:41PM +0000, Ernst, Justin wrote:
> > The combined patches work on a 20 socket system. 
> > Thanks!
> 
> Cool, thanks for testing.
> 
> Nevertheless, I'll queue them for 4.21 so that we have a full cycle of
> testing before we really kill the bus thing.

Ok, I've pushed the two patches ontop of EDAC's for-next branch, here:

https://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git/log/?h=edac-for-4.21-bus

and I'd appreciate testing them one more time on the big boxes you guys have.

Diffing sysfs here shows this:


which is the bus symlink:

subsystem -> ../../../../../../bus/mc0

and I think that's ok as nothing should be using it.

Thx.
Justin Ernst - Nov. 13, 2018, 7:09 p.m.
Looks good on a 32 socket system. All 64 memory controllers show up and I'm able to see the same sysfs diff.
Thanks
-Justin

> -----Original Message-----

> From: Borislav Petkov [mailto:bp@alien8.de]

> Sent: Tuesday, November 6, 2018 8:46 AM

> To: Ernst, Justin <justin.ernst@hpe.com>; Luck, Tony <tony.luck@intel.com>

> Cc: Greg KH <gregkh@linuxfoundation.org>; Anderson, Russ

> <russ.anderson@hpe.com>; Mauro Carvalho Chehab

> <mchehab@kernel.org>; linux-edac@vger.kernel.org; linux-

> kernel@vger.kernel.org; Aristeu Rozanski Filho <arozansk@redhat.com>

> Subject: Re: [PATCH] EDAC: Don't add devices under /sys/bus/edac

> 

> On Tue, Oct 02, 2018 at 06:26:08PM +0200, Borislav Petkov wrote:

> > On Tue, Oct 02, 2018 at 03:51:41PM +0000, Ernst, Justin wrote:

> > > The combined patches work on a 20 socket system.

> > > Thanks!

> >

> > Cool, thanks for testing.

> >

> > Nevertheless, I'll queue them for 4.21 so that we have a full cycle of

> > testing before we really kill the bus thing.

> 

> Ok, I've pushed the two patches ontop of EDAC's for-next branch, here:

> 

> https://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git/log/?h=edac-for-

> 4.21-bus

> 

> and I'd appreciate testing them one more time on the big boxes you guys

> have.

> 

> Diffing sysfs here shows this:

> 

> --- edac.before	2018-11-06 13:37:37.925448609 +0100

> +++ edac.after	2018-11-06 15:36:11.229497795 +0100

> @@ -37,7 +37,6 @@

>  /sys/devices/system/edac/mc/mc0/dimm3/power/control

>  /sys/devices/system/edac/mc/mc0/dimm3/dimm_dev_type

>  /sys/devices/system/edac/mc/mc0/dimm3/size

> -/sys/devices/system/edac/mc/mc0/dimm3/subsystem

>  /sys/devices/system/edac/mc/mc0/dimm3/dimm_ce_count

>  /sys/devices/system/edac/mc/mc0/dimm3/dimm_label

>  /sys/devices/system/edac/mc/mc0/dimm3/dimm_location

> 

> which is the bus symlink:

> 

> subsystem -> ../../../../../../bus/mc0

> 

> and I think that's ok as nothing should be using it.

> 

> Thx.

> 

> --

> Regards/Gruss,

>     Boris.

> 

> Good mailing practices for 400: avoid top-posting and trim the reply.
Borislav Petkov - Nov. 13, 2018, 7:15 p.m.
On Tue, Nov 13, 2018 at 07:09:24PM +0000, Ernst, Justin wrote:
> Looks good on a 32 socket system. All 64 memory controllers show up
> and I'm able to see the same sysfs diff. Thanks

Thanks for testing, much appreciated!

I'm queuing the stuff for 4.21.

Patch

--- edac.before	2018-11-06 13:37:37.925448609 +0100
+++ edac.after	2018-11-06 15:36:11.229497795 +0100
@@ -37,7 +37,6 @@ 
 /sys/devices/system/edac/mc/mc0/dimm3/power/control
 /sys/devices/system/edac/mc/mc0/dimm3/dimm_dev_type
 /sys/devices/system/edac/mc/mc0/dimm3/size
-/sys/devices/system/edac/mc/mc0/dimm3/subsystem
 /sys/devices/system/edac/mc/mc0/dimm3/dimm_ce_count
 /sys/devices/system/edac/mc/mc0/dimm3/dimm_label
 /sys/devices/system/edac/mc/mc0/dimm3/dimm_location