Patchwork [v10,1/6] edac: synopsys: Add error handling for NULL in probe()

login
register
mail settings
Submitter Manish Narani
Date Oct. 25, 2018, 6:06 a.m.
Message ID <1540447621-22870-2-git-send-email-manish.narani@xilinx.com>
Download mbox | patch
Permalink /patch/643443/
State New
Headers show

Comments

Manish Narani - Oct. 25, 2018, 6:06 a.m.
The function of_device_get_match_data() can return NULL in case of
error. Add error handling for the same in probe().

Signed-off-by: Manish Narani <manish.narani@xilinx.com>
---
 drivers/edac/synopsys_edac.c | 3 +++
 1 file changed, 3 insertions(+)

Patch

diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c
index 1c3795d..0005ef3 100644
--- a/drivers/edac/synopsys_edac.c
+++ b/drivers/edac/synopsys_edac.c
@@ -477,6 +477,9 @@  static int mc_probe(struct platform_device *pdev)
 		return PTR_ERR(baseaddr);
 
 	p_data = of_device_get_match_data(&pdev->dev);
+	if (!p_data)
+		return -ENODEV;
+
 	if (!p_data->get_ecc_state(baseaddr)) {
 		edac_printk(KERN_INFO, EDAC_MC, "ECC not enabled\n");
 		return -ENXIO;