Patchwork efi: Fix debugobjects warning on efi_rts_work

login
register
mail settings
Submitter Waiman Long
Date Oct. 23, 2018, 2:18 p.m.
Message ID <1540304307-2806-1-git-send-email-longman@redhat.com>
Download mbox | patch
Permalink /patch/642303/
State New
Headers show

Comments

Waiman Long - Oct. 23, 2018, 2:18 p.m.
The commit 9dbbedaa6171 ("efi: Make efi_rts_work accessible to efi
page fault handler") converted efi_rts_work from an auto variable to a
global variable. However, when submitting the work, INIT_WORK_ONSTACK()
was still used causing the following complaint from debugobjects:

ODEBUG: object 00000000ed27b500 is NOT on stack 00000000c7d38760,
but annotated.

Change the macro to just INIT_WORK() to eliminate the warning.

Fixes: 9dbbedaa6171 ("efi: Make efi_rts_work accessible to efi page fault handler")

Signed-off-by: Waiman Long <longman@redhat.com>
---
 drivers/firmware/efi/runtime-wrappers.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Sai Praneeth Prakhya - Oct. 23, 2018, 4:43 p.m.
> -----Original Message-----
> From: Waiman Long [mailto:longman@redhat.com]
> Sent: Tuesday, October 23, 2018 7:18 AM
> To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: linux-efi@vger.kernel.org; linux-kernel@vger.kernel.org; Prakhya, Sai
> Praneeth <sai.praneeth.prakhya@intel.com>; Waiman Long
> <longman@redhat.com>
> Subject: [PATCH] efi: Fix debugobjects warning on efi_rts_work
> 
> The commit 9dbbedaa6171 ("efi: Make efi_rts_work accessible to efi page fault
> handler") converted efi_rts_work from an auto variable to a global variable.
> However, when submitting the work, INIT_WORK_ONSTACK() was still used
> causing the following complaint from debugobjects:
> 
> ODEBUG: object 00000000ed27b500 is NOT on stack 00000000c7d38760, but
> annotated.
> 
> Change the macro to just INIT_WORK() to eliminate the warning.
> 
> Fixes: 9dbbedaa6171 ("efi: Make efi_rts_work accessible to efi page fault
> handler")

Thanks for fixing this :)
Looks good to me.

Regards,
Sai
Ard Biesheuvel - Nov. 5, 2018, 1:01 p.m.
On 23 October 2018 at 18:43, Prakhya, Sai Praneeth
<sai.praneeth.prakhya@intel.com> wrote:
>
>
>> -----Original Message-----
>> From: Waiman Long [mailto:longman@redhat.com]
>> Sent: Tuesday, October 23, 2018 7:18 AM
>> To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Cc: linux-efi@vger.kernel.org; linux-kernel@vger.kernel.org; Prakhya, Sai
>> Praneeth <sai.praneeth.prakhya@intel.com>; Waiman Long
>> <longman@redhat.com>
>> Subject: [PATCH] efi: Fix debugobjects warning on efi_rts_work
>>
>> The commit 9dbbedaa6171 ("efi: Make efi_rts_work accessible to efi page fault
>> handler") converted efi_rts_work from an auto variable to a global variable.
>> However, when submitting the work, INIT_WORK_ONSTACK() was still used
>> causing the following complaint from debugobjects:
>>
>> ODEBUG: object 00000000ed27b500 is NOT on stack 00000000c7d38760, but
>> annotated.
>>
>> Change the macro to just INIT_WORK() to eliminate the warning.
>>
>> Fixes: 9dbbedaa6171 ("efi: Make efi_rts_work accessible to efi page fault
>> handler")
>
> Thanks for fixing this :)
> Looks good to me.
>
> Regards,
> Sai

Thanks

Queued in efi/urgent (with Sai's ack)

Patch

diff --git a/drivers/firmware/efi/runtime-wrappers.c b/drivers/firmware/efi/runtime-wrappers.c
index a19d845..8903b9c 100644
--- a/drivers/firmware/efi/runtime-wrappers.c
+++ b/drivers/firmware/efi/runtime-wrappers.c
@@ -67,7 +67,7 @@ 
 	}								\
 									\
 	init_completion(&efi_rts_work.efi_rts_comp);			\
-	INIT_WORK_ONSTACK(&efi_rts_work.work, efi_call_rts);		\
+	INIT_WORK(&efi_rts_work.work, efi_call_rts);			\
 	efi_rts_work.arg1 = _arg1;					\
 	efi_rts_work.arg2 = _arg2;					\
 	efi_rts_work.arg3 = _arg3;					\